• Resolved spherman

    (@spherman)


    I spent a few hours today trying to track down what was making the shop pages on my client’s site not work. They use foxycart. I asked foxycart for help and were not helpful.

    When I would go to the shop page, I would see a broken version of the template with a message that said, “There has been a critical error on this website.”.

    I finally narrowed it down to My Calendar 3.3.18 as a conflicting plugin. I was able to restore from backups version 3.3.17 and it is all working as expected now, but I am concerned as this was a security update.

    Can someone please address this?

Viewing 4 replies - 1 through 4 (of 4 total)
  • Same issue on my end. Updating to v3.3.18 crashed my website. Here is the error from the server logs.

    2022/08/17 14:48:14 [error] 204#204: *8623 FastCGI sent in stderr: "PHP message: PHP Fatal error:  Uncaught ArgumentCountError: Too few arguments to function mc_search_results_title(), 1 passed in /public/wp-includes/class-wp-hook.php on line 307 and exactly 2 expected in /public/wp-content/plugins/my-calendar/my-calendar-search.php:164
    Stack trace:
    #0 /public/wp-includes/class-wp-hook.php(307): mc_search_results_title('Get Legal Help')
    #1 /public/wp-includes/plugin.php(191): WP_Hook->apply_filters('Get Legal Help', Array)
    #2 /public/wp-content/themes/Trim-child/home.php(11): apply_filters('the_title', 'Get Legal Help')
    #3 /public/wp-includes/template-loader.php(106): include('/www/site...')
    #4 /public/wp-blog-header.php(19): require_once('/www/site...')
    #5 /public/index.php(17): require('/www/site...')
    #6 {main}
      thrown in /public/wp-content/plugins/my-calendar/my-cal" while reading upstream, client: 72.20.212.2, server: www.site.com, request: "GET / HTTP/1.1", upstream: "fastcgi://unix:/var/run/php7.4-fpm-site.sock:", host: "www.site.com"
    
    Thread Starter spherman

    (@spherman)

    My issue was resolved by Foxcart.

    Here is their response. Their fix worked.

    I hope this helps someone.

    ___

    Quick follow-up – we were able to replicate the issue that you noted, and it appears to relate to a legacy usage of the “the_title” hook. We’ll prep an update for that to get released hopefully pretty soon. If you’d like in the meantime, you can make the code changes directly yourself to be able to then use the latest version of the calendar plugin.

    In helperfunctions.php, there are three lines to update that include this:
    apply_filters(‘the_title’, $product[‘name’])

    These lines should be on (or around) lines 1307, 1316 and 1384. You’ll update each of those to pass an additional argument, so it looks like this:
    apply_filters(‘the_title’, $product[‘name’], $product[‘id’])

    There are also three impacted files in the “themefiles” folder, “foxyshop-product-loop.php”, “foxyshop-single-product.php” and “foxyshop-single-product-shortcode.php”. It would be worth updating those as well, but note that if you have a modified version of these files in your own theme folder, you’ll need to update them there too.

    _____

    more….

    Quick follow-up just to clarify – the changes I described would be made on files within the “foxyshop” plugin folder, with the exception of any of those theme files that you have potentially customised in your own theme folder.

    Thanks again for bringing this to our attention and letting us know which plugin was triggering the conflict.

    Plugin Author Joe Dolson

    (@joedolson)

    Yes, this looks like a bug in Foxycart that was triggered by an update in My Calendar. Thanks for letting me know, although it looks like this requires an update by Foxycart.

    Thread Starter spherman

    (@spherman)

    Thanks.

    I am working with Foxycart to get it resolved.

Viewing 4 replies - 1 through 4 (of 4 total)

The topic ‘Plugin Conflict’ is closed to new replies.