Plugin conflicts & Critical issues.

  • Resolved Biplav

    (@bplv)


    7 years, 1 month ago

    Hi guys wonderful work on the plugin.
    I have a couple of issues that I think are quite critical and should be addressed on the next update

    1. Please enqueue your admin Js on your admin pages only instead of loading it globally on every pages.
    2. User proper enqueue hooks, I had problem with the dequeue on a child theme because the enqueue was not properly hooked.
    3. According to plugin guidelines I don’t think you’re allowed to use a CDN or a weblink for any css/js files and you’re also supposed to include unminified files on the plugin whenever you are using a minified file. ( I am not sure if this is updated on the guidelines for now, but this was a requirement last time I checked.)

    Again, thank you for the plugin. 🙂
    Regards.

Viewing 4 replies - 1 through 4 (of 4 total)
  • David Ly Khim

    (@davidlykhim)

    7 years, 1 month ago

    Hi Biplav, thank you for the feedback! I’ve responded to your points below. Short version is, we’re aware of these and working on them!

    1. Please enqueue your admin Js on your admin pages only instead of loading it globally on every pages.
    This is something we’re working on and plan to fix in following releases.

    2. User proper enqueue hooks, I had problem with the dequeue on a child theme because the enqueue was not properly hooked.
    Thanks for surfacing this. Could you share more details on what problem you were having?

    3. According to plugin guidelines I don’t think you’re allowed to use a CDN or a weblink for any css/js files and you’re also supposed to include unminified files on the plugin whenever you are using a minified file.
    We’ve fixed this in our lastest version.

    Thanks! 🙂

    • This reply was modified 7 years, 1 month ago by David Ly Khim. Reason: Would like to learn more about the problem
    Thread Starter Biplav

    (@bplv)

    7 years, 1 month ago

    @davidlykhim
    Thank you! 🙂

    Sorry if I wasn’t clear on the second point.
    Instead of using admin_print_scripts could you use admin_enqueue_scripts unless there’s a specific reason to use the print scripts hook?

    • This reply was modified 7 years, 1 month ago by Biplav.
    David Ly Khim

    (@davidlykhim)

    6 years, 10 months ago

    Hi @bplv are you still having issues with this? We’ve released a couple updates that should have addressed this issue.

    Thread Starter Biplav

    (@bplv)

    6 years, 10 months ago

    Yep, works as expected now.
    Thanks

Viewing 4 replies - 1 through 4 (of 4 total)

The topic ‘Plugin conflicts & Critical issues.’ is closed to new replies.