[Plugin: Customizable Etsy Widget] plugin not saving and some error handling fix

  • Resolved alx359

    (@alx359)


    14 years, 11 months ago

    Hi Sneddo,

    Thanks for the great plugin!

    A suggestion:

    I had the widget not being saved in the sidebar, so after “define(‘WP_DEBUG’,true)” in wp-config.php, found my dev system had not extension=php_curl.dll enabled in php.ini. I’d suggest you add some error handling like this in CustomizableEtsyWidget.php ~ li 278

    ////[alx359] check curl installed or plugin doesn't work
if (!function_exists('curl_init')) { // check curl
	echo __('<b>curl() is needed! Enable in php.ini</b>','CustomizableEtsyWidget');
	die();
}
////
$ch = curl_init($url);

    Cheers!
    Alex

    http://ww.wp.xz.cn/extend/plugins/customizable-etsy-widget/

Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Author Sneddo

    (@sneddo)

    14 years, 11 months ago

    Hey Alex,

    Thanks for the feedback!

    Haven’t come across this issue yet, but the more error handling the better. I’ll put this in the next release 🙂

    Cheers,
    Sneddo

    Thread Starter alx359

    (@alx359)

    14 years, 11 months ago

    Testing now. May think of a small feature too:

    – Put (part of) the CSS in the admin box. Now I’ve added

    .etsyItemTable td a img { border: 1px #000; border-style:solid;  }

    in customizableetsywidget_head_css() and get a lot of nicer display of the small thumbs.

    Plugin Author Sneddo

    (@sneddo)

    14 years, 11 months ago

    Yeah, I guess I could do that. The CSS is mostly just to display them evenly, with the actual look and feel left for the end user to customise. But perhaps I need to look at this sometime…

    Thread Starter alx359

    (@alx359)

    14 years, 11 months ago

    Etsy doesn’t return proper entities in links and the WP pages do not validate anymore (my theme at least does in the most part).

    The quick-fix that is working for me was escaping the urls:

    ~ li 376 CustomizableEtsyWidget.php

    echo '<td>';
if ($k < $numitems) {
	echo '<a href="' . htmlspecialchars($item->url) . '" title="' . $item->title . '">';
	if ($instance['imgsize'] == '75x75')
		echo '<img src="' . htmlspecialchars($item->Images[0]->url_75x75) . '" alt="' . $item->title . '" />';
	if ($instance['imgsize'] == '170x135')
		echo '<img src="' . htmlspecialchars($item->Images[0]->url_170x135) . '" alt="' . $item->title . '" />';
	echo '</a>';
}
echo "</td>";

    (tested with HTML Validator for FF)

    Plugin Author Sneddo

    (@sneddo)

    14 years, 11 months ago

    Hey Alex,

    I’ve just uploaded a new version which incorporates all your input as well as updating to the new Etsy API URLs.

    Thanks for your input, and please let me know if there is anything else I can add 🙂

    Cheers,
    Sneddo

    Thread Starter alx359

    (@alx359)

    14 years, 11 months ago

    Sneddo, hi there! 🙂

    Good job, looks great! Just changed text-align:left as it better suits the site I’m doing (and its the default of the other sidebars, I think).

    New ideas to add I have not for now. Your plugin perfectly suits me!

    (BTW, thanks, but no need to keep ref to the suggested fix in code. I do tags just to find my hacks quickly when updates come).

    Cheers!
    Alex

    Plugin Author Sneddo

    (@sneddo)

    14 years, 11 months ago

    I believe in credit where credit is due 🙂

    I have a few more ideas, but we’ll see what eventuates….

Viewing 7 replies - 1 through 7 (of 7 total)

The topic ‘[Plugin: Customizable Etsy Widget] plugin not saving and some error handling fix’ is closed to new replies.