[Plugin: Edit Flow] Custom statuses create timestamp problem

Had to take a break this weekend for WordCamp San Francisco but I’m still working on it.

Hey there,
Third time’s the charm, right? 🙂 I think I finally have a fix for you. Try replacing those existing code snippets with the following block:

add_filter( 'admin_init', array( 'ef_check_timestamp_on_publish' ) );
add_filter( 'wp_insert_post_data', array( 'ef_fix_custom_status_timestamp' ) );
/**
 * This is a hack! hack! hack! until core is fixed/better supports custom statuses
 *
 * When publishing a post with a custom status, set the status to 'pending' temporarily
 * Works around this limitation: http://core.trac.ww.wp.xz.cn/browser/tags/3.2.1/wp-includes/post.php#L2694
 * Original thread: http://ww.wp.xz.cn/support/topic/plugin-edit-flow-custom-statuses-create-timestamp-problem
 * Core ticket: http://core.trac.ww.wp.xz.cn/ticket/18362
 */
function ef_check_timestamp_on_publish() {
	global $edit_flow, $pagenow, $wpdb;

	if ( !isset( $edit_flow ) || $pagenow != 'post.php' || !isset( $_POST['publish'] ) )
		return false;

	// Set the post_status as 'pending' only when there's no timestamp set for $post_date_gmt
	if ( isset( $_POST['post_ID'] ) ) {
		$post_id = (int) $_POST['post_ID'];
		$wpdb->update( $wpdb->posts, array( 'post_status' => 'pending' ), array( 'ID' => $post_id, 'post_date_gmt' => '0000-00-00 00:00:00' ) );
	}

}
/**
 * This is a hack! hack! hack! until core is fixed/better supports custom statuses
 *
 * Normalize post_date_gmt if it isn't set to the past or the future
 * Works around this limitation: http://core.trac.ww.wp.xz.cn/browser/tags/3.2.1/wp-includes/post.php#L2506
 * Original thread: http://ww.wp.xz.cn/support/topic/plugin-edit-flow-custom-statuses-create-timestamp-problem
 * Core ticket: http://core.trac.ww.wp.xz.cn/ticket/18362
 */
function ef_fix_custom_status_timestamp( $data ) {
	global $edit_flow, $pagenow;
	// Don't run this if Edit Flow isn't active, or we're on some other page
	if ( !isset( $edit_flow ) || $pagenow != 'post.php' || !isset( $_POST ) )
		return $data;
	$custom_statuses = get_terms( 'post_status', array( 'get' => 'all' ) );
	$status_slugs = array();
	foreach( $custom_statuses as $custom_status )
	    $status_slugs[] = $custom_status->slug;
	$ef_normalize_post_date_gmt = true;
	// We're only going to normalize the post_date_gmt if the user hasn't set a custom date in the metabox
	// and the current post_date_gmt isn't already future or past-ized
	foreach ( array('aa', 'mm', 'jj', 'hh', 'mn') as $timeunit ) {
		if ( !empty( $_POST['hidden_' . $timeunit] ) && (($_POST['hidden_' . $timeunit] != $_POST[$timeunit] ) || ( $_POST['hidden_' . $timeunit] != $_POST['cur_' . $timeunit] )) ) {
			$ef_normalize_post_date_gmt = false;
			break;
		}
	}
	if ( $ef_normalize_post_date_gmt )
		if ( in_array( $data['post_status'], $status_slugs ) )
			$data['post_date_gmt'] = '0000-00-00 00:00:00';
	return $data;
}

@redhooded Did you add this code snippet to the functions.php file in your theme? I was able to bulk edit posts just fine with it.

Awesome to hear this is fixed… thanks so much for helping me test it out.

I’ll take a look at the bulk editing bug when I have a chance in the next few days. I’ve confirmed it on my end.

I’ve figured it out. If you’d like, I can post an updated snippet. I think I’d prefer to refrain from posting about it because I’d rather just focus on getting the next release out and not have to worry about people copy and pasting code.