[Plugin: Editorial Calendar] Load assets over HTTPS

  • Resolved Anonymous User 92042

    (@anonymized-92042)


    13 years, 10 months ago

    First I want to say that Editorial Calendar is a fantastic piece of work, easily one of the nicest WP plugins I use.

    One issue I have though is that all its static assets — CSS, JS, and images — are loaded via HTTP regardless of how WP Admin itself is loaded. We require SSL for our admin area via FORCE_SSL_ADMIN but the plugin loads these files via plain text HTTP.

    This causes scary messages in some browsers and if a writer chooses to not load the insecure assets, the calendar does not load at all (this happened to one of our writers).

    Overall great work though, so I’d love to see this one issue fixed. Thanks!

    http://ww.wp.xz.cn/extend/plugins/editorial-calendar/

Viewing 5 replies - 1 through 5 (of 5 total)
  • Zack Grossbart

    (@zgrossbart)

    13 years, 10 months ago

    Thanks for using the Editorial Calendar. We’re loading all of our assets with relative URLs so it should use whatever protocol the page loaded with. We also embedding our CSS and JavaScript in the page.

    The one place we do load images from CSS, but we’re getting the path to those from WordPress.

    I don’t have the calendar running over SSL so I can’t reproduce this issue. Do you know which files are causing the issue? Any chance I could log into your blog and see the problem?

    Thanks,
    Zack

    Thread Starter Anonymous User 92042

    (@anonymized-92042)

    13 years, 10 months ago

    Thanks for the quick response, Zack. I can’t give you a login to the site, but if you give me an email address I can send you a copy of the generated HTML for the calendar page.

    But here’s the list of plugin files that are loaded over plain HTTP:

    • editorial-calendar/lib/languages/date-en-US.js
    • editorial-calendar/lib/edcallib.min.js
    • editorial-calendar/images/tip_close.png

    And WP images that are loaded by the calendar:

    • wp-admin/images/loading.gif
    • wp-admin/images/button-grad.png

    The images are all loaded as CSS background images, from an inline style block. The JS looks to be loaded via wp_head().

    Zack Grossbart

    (@zgrossbart)

    13 years, 10 months ago

    Thanks for the help tracking this down. I found the problem. The calendar was loading the relative files with the wrong function. I tracked down the right function and changed the way we load these files so it should work for SSL, but I’m not set up to test it.

    If I can send you an updated file would you be willing to try it out?

    Thanks,
    Zack

    Thread Starter Anonymous User 92042

    (@anonymized-92042)

    13 years, 10 months ago

    Sure, you can send it to the email address on this page:
    http://www.corvidworks.com/contact/

    Zack Grossbart

    (@zgrossbart)

    13 years, 10 months ago

    We’ve released a new version of the calendar that calls the plugins_url function to build the URL to these resources and uses SSL correctly. This is released in the latest version of the calendar. However, Kenn is running into a core WordPress issue (http://core.trac.ww.wp.xz.cn/ticket/16953) and we’re still working on a way around it.

Viewing 5 replies - 1 through 5 (of 5 total)

The topic ‘[Plugin: Editorial Calendar] Load assets over HTTPS’ is closed to new replies.