Plugin Author
axew3
(@axewww)
yes, at first fast look into, the problem come out on
class.wp.w3all-phpbb.php
where update of profile fields are compared with phpBB values:
if( $phpbb_user_session[0]->user_password != $current_user->user_pass OR $phpbb_user_session[0]->user_email != $current_user->user_email <strong>OR $phpbb_user_session[0]->pf_phpbb_website != $current_user->user_url</strong> ){
$wpu_db_utab = $wpdb->prefix . 'users';
$phpbb_upass = $phpbb_user_session[0]->user_password;
$phpbb_uemail = $phpbb_user_session[0]->user_email;
$phpbb_uurl = $phpbb_user_session[0]->pf_phpbb_website;
$wpdb->query("UPDATE $wpu_db_utab SET user_pass = '$phpbb_upass', user_email = '$phpbb_uemail', user_url = '$phpbb_uurl' WHERE ID = '$current_user->ID'");
if ( defined( 'WP_ADMIN' ) ) { // going on profile directly from forum iframe for example, update onload user's profile fields
wp_redirect( admin_url().'profile.php', $status );
exit;
}
}
this is the problem.
I’ve try out on fly and work if this is commented out.
Yes there are several solutions. This piece of code was added on wp_w3all to update profile fields of users, if they was coming, after an update of there profiles in phpBB, directly to wp profile page to let see at same time, profile fields updated as on phpBB where done; without this code, a refresh of the profile page, or profile page as second page visited on wp, was required (hope this explain is clear with my bad english).
If In this installation, users will not have possibility to edit there profile in phpBB and are redirected to wp profile if they try to access phpBB ucp profile page, than just remove the above code.
Another solution is to detect when this, or others plugins, are updating profile fields, excluding this part of code in this case.
Or i think another one but i should try.
As soon i can i will take a look.
Plugin Author
axew3
(@axewww)
good morning mad world, this the easy solution to the problem above.
Wrap the above code into this (this will be applied by default for compatibility, i presume also with many other plugins, into next wp_w3all release):
if( $_GET['updated'] != 1 ){
so, the above i’ve suggest to remove, should be instead just replaced by this:
if( $_GET['updated'] != 1 ){
$phpbb_user_session[0]->pf_phpbb_website = (isset($phpbb_user_session[0]->pf_phpbb_website)) ? $phpbb_user_session[0]->pf_phpbb_website : '';
if( $phpbb_user_session[0]->user_password != $current_user->user_pass OR $phpbb_user_session[0]->user_email != $current_user->user_email OR $phpbb_user_session[0]->pf_phpbb_website != $current_user->user_url ){
$wpu_db_utab = $wpdb->prefix . 'users';
$phpbb_upass = $phpbb_user_session[0]->user_password;
$phpbb_uemail = $phpbb_user_session[0]->user_email;
$phpbb_uurl = $phpbb_user_session[0]->pf_phpbb_website;
$wpdb->query("UPDATE $wpu_db_utab SET user_pass = '$phpbb_upass', user_email = '$phpbb_uemail', user_url = '$phpbb_uurl' WHERE ID = '$current_user->ID'");
if ( defined( 'WP_ADMIN' ) ) { // going on profile directly from forum iframe for example, update onload user's profile fields
wp_redirect( admin_url().'profile.php', $status );
exit;
}
}
}
If any other problem … here we are 😉
Plugin Author
axew3
(@axewww)
ah yes … should be solved so …
[solved]
Plugin Author
axew3
(@axewww)
yes yes, i forget many times so sorry … crazy …
[solved]
Thread Starter
rivoq
(@rivoq)
Just to thank you for your amazing job. I didn’t had the time to look at this this week after my initial post but I had to test it tonight and the fix works perfectly. I really appreciate.
Edit:
Ooops… Looks like there still are a problem… The saving is not running indefinitely like it did before, it seems to be saving. But if I refresh the page after the save the change made just disapears… :/
Plugin Author
axew3
(@axewww)
good morning! Yes rivoq, within today, if i will find out the time or tomorrow, 1.4.7 will be released to fix all about this and others plugins: yes unfortunately, doing things on fly, sometime isn’t good. In fact there is another problem on a query i’ve see: if the field on phpBB do not exist about url on respective phpBB db table, a query fail, wp_w3all do not populate this filed on phpBB, and the joke do not work.
coming 1.4.7
Thread Starter
rivoq
(@rivoq)
Ok, that makes sense. 🙂
No rush for me, et site is still in development and not officially online. But I’m really happy with the fact that you are available to discuss about bugs and are really working to fix them when they are real,and not just publishing a plugin then ignoring customers like many. That is really appreciated.
I’ll wait for the 1.4.7.
Best regards.
Alex
