[Plugin: Lazy Load] Incompatibility with Leaflet Maps Marker

  • Robert Seyfriedsberger

    (@harmr)


    13 years, 8 months ago

    I am the developer of the mapping plugin Leaflet Maps Marker (http://www.mapsmarker.com) and a user reported that your plugin is causing my maps to break. This is because your plugin adds unescaped ” to my javascript code which is causing the maps to break:

    var osm_mapnik = new L.TileLayer("http://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png", {maxZoom: 18, minZoom: 1, errorTileUrl: "http://current.mapsmarker.com/wp-content/plugins/leaflet-maps-marker/inc/img/error-tile-image.png", attribution: "Map: &copy; 2012 <a href=\"http://www.openstreetmap.org\" target=\"_blank\">OpenStreetMap contributors</a>, <a href=\"http://creativecommons.org/licenses/by-sa/2.0/\" target=\"_blank\">CC-BY-SA</a>", detectRetina: true});

    I tried to fix this in my plugin but didnt succeed. Could you therefore please change your script in the way that code within <script*>-tags gets ignored? Otherwise I can advise my users only to disable you plugin – which is not what I want…
    regards,

    Robert

    http://ww.wp.xz.cn/extend/plugins/lazy-load/

Viewing 5 replies - 1 through 5 (of 5 total)
  • maraki

    (@neodjandre)

    13 years, 3 months ago

    Hello Robert,

    I am not the plugin owner but i tested Lazy Load with 3.5.2 of Leaflet Maps Marker and it appears to work fine..

    The only problem is the red popup that Leaflet Maps Marker produces which says to disable Lazy Load..

    Should i be testing something specific here?

    maraki

    (@neodjandre)

    13 years, 3 months ago

    Actually that was with v3.4.2 of WordPress!

    Just upgraded to v3.5.1 of WordPress and i confirm that the map appears broken when Lazy Load plugin is active..

    so it’s something to do with wordpress v3.5.1 i guess !

    Hope to resolve this soon as I like both plugins x

    Thread Starter Robert Seyfriedsberger

    (@harmr)

    13 years, 3 months ago

    Lazy Load breaks my plugin – I tried to solve this but didnt succeed – this is something the plugin author of Lazy Load should take care of – I contacted him but unfortunately there has been no update yet. it would be great if you could contact him and redirect him to this thread where I already outlined a possible solution for him (ignoring code in <script>-tags.
    best,
    Robert

    Thread Starter Robert Seyfriedsberger

    (@harmr)

    13 years, 3 months ago

    anyway I will test again to check….

    Thread Starter Robert Seyfriedsberger

    (@harmr)

    13 years, 3 months ago

    checked the plugin lazy load again – you´re right: it is working with Leaflet Maps Marker now as I introduced loading javascripts in footer where lazy load doesnt change my code.
    Nethertheless maps dont show if you use WordPress <3.3 or set javascript inclusion to header. Will update the compatibility check to only show the warning if this is true…
    Thanks for pointing this out!

Viewing 5 replies - 1 through 5 (of 5 total)

The topic ‘[Plugin: Lazy Load] Incompatibility with Leaflet Maps Marker’ is closed to new replies.