[Plugin: Posts 2 Posts] Enable other input types in meta values

Resolved palmtrae
(@palmtrae)

14 years, 6 months ago
Hi, i’ve been adding these four lines in fields.php:139
```
if ( isset( $this->data['type'] ) ) {
  $args['type'] = $this->data['type'];
  $args['value'] = $this->data['values'];
}
```
The reason for this is that i needed to add a checkbox type of field, and when I looked at your code i saw that there was support for other input types than text and select. This might be something you want to include in future releases.

Also, the resulting code might not be perfect, but it wont break backwards compatibility with your recently added select field feature.

Usage:
```
p2p_register_connection_type( array(
	'id' => 'posts_to_pages',
	'from' => 'post',
	'to' => 'page',

	'fields' => array(
		'types' => array(
			'title' => 'Type',
			'type' => 'radio',
			'values' => array( 'strong', 'weak' )
		),

		'display' => array(
			'title' => 'Display strength',
			'type' => 'checkbox',
			'values' => 1
		),
	)
) );
```
Cheers

http://ww.wp.xz.cn/extend/plugins/posts-to-posts/

Viewing 8 replies - 1 through 8 (of 8 total)

Plugin Author scribu
(@scribu)

14 years, 6 months ago
I didn’t allow it because a whole column with a single checkbox and no label text looks weird and is hard to click.

You could do this though:
```
'title' => 'Display strength',
'type' => 'checkbox',
'values' => array( true => 'yes' )
```
Note that the checkbox value would not be saved correctly, just by modifying fields.php. You would not be able to uncheck it.
Thread Starter palmtrae
(@palmtrae)

14 years, 6 months ago
It actually looks quite alright, but you are of course correct about not being able to uncheck it, there needs to be another adjustment for that also, i can take a look 🙂
http://pix.thefarm.se/palmtrae/20111111130121/

About the label, yes of course thats the way to do that 🙂
http://pix.thefarm.se/palmtrae/20111111130442/ just need to update the css a bit
```
.p2p-connections td input[type="radio"],
.p2p-connections td input[type="checkbox"] {
	width: auto;
}
```
Textareas work nicely, as long as the admin widget is not on the right hand column.
Plugin Author scribu
(@scribu)

14 years, 6 months ago

https://github.com/scribu/wp-posts-to-posts/issues/47

Plugin Author scribu
(@scribu)

14 years, 6 months ago

Pushed to the development version (0.9.6-alpha3).

Thread Starter palmtrae
(@palmtrae)

14 years, 6 months ago

Nice!

Alright, i’ve looked at the changes you’ve made, however it still won’t detect an unchecked value. The reason is simple, when you loop through all p2p_ids, the p2p_id that is unchecked is never posted see here http://pix.thefarm.se/palmtrae/20111114083123/
Notice in the p2p_order array there’s a third value not seen in p2p_meta.

A possible solution would be to add a hidden p2p_id key for each connected post, then the code you added to check checkbox values would work perfectly.

Plugin Author scribu
(@scribu)

14 years, 6 months ago

Ah, yes. I didn’t catch that because I had other fields that weren’t checkboxes.

https://github.com/scribu/wp-posts-to-posts/issues/49

Plugin Author scribu
(@scribu)

14 years, 6 months ago

This should be fixed in the development version (1.0.1-alpha2).

Thread Starter palmtrae
(@palmtrae)

14 years, 6 months ago

Great work! This is one of the most useful plugins for wordpress imho, and the rate it’s updated is excellent 🙂

Keep it up!

Viewing 8 replies - 1 through 8 (of 8 total)

The topic ‘[Plugin: Posts 2 Posts] Enable other input types in meta values’ is closed to new replies.