[Plugin: Revision Control] Small bug found & suggestion: version 2.1

  • PDMowster

    (@pedrodm)


    14 years, 9 months ago

    1. Small bug found
    The AJAX request has Failed, Please try again;
    Then unexpected data was: [obeject Document]
    It happens when user clicks delete without any revision selected

    2. Suggestion
    When you click all messages to delete, it selects the current version. Although it does not delete it looks creepy and sounds it is going to delete the main post because the bar turns red.
    It may not select the current version and the auto-save to avoid becoming red when the user deletes everything.

    I’ve been using this plugin for a long time.
    Congratulation regarding your work!

    http://ww.wp.xz.cn/extend/plugins/revision-control/

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author Dion Hulse

    (@dd32)

    Meta Developer

    14 years, 9 months ago

    Thanks for reporting it Pedro, I’ve replied to your email.

    Thread Starter PDMowster

    (@pedrodm)

    14 years, 9 months ago

    Bugs solutions

    File revision-control.php

    # bug_1
    __(‘Post Revisions’, ‘revision-control’) missing not allowing to be shown translated.

    Current
    line 83. add_meta_box(‘revisionsdiv’, __(‘Post Revisions’), array(‘Plugin_Revision_Control_UI’, ‘revisions_meta_box’), $type, ‘normal’);

    fix
    line 83. add_meta_box(‘revisionsdiv’, __(‘Post Revisions’, ‘revision-control’), array(‘Plugin_Revision_Control_UI’, ‘revisions_meta_box’), $type, ‘normal’);

    # bug_2
    It will hide checkbox in current revision and autosave, not allowing to be selected by check all function

    current
    line 616. <input type=’checkbox’ name=’checked[]’ class=’checklist toggle-type’ value=’$revision->ID’ $deletedisabled />
    line 617. </span>

    fix
    line 616. “; if (empty($deletedisabled)) echo “<input type=’checkbox’ name=’checked[]’ class=’checklist toggle-type’ value=’$revision->ID’ $deletedisabled />”;
    line 617. echo ” </span>

    File revision-control.js
    # bug_3
    When clicking delete without any revision selected it was outputing the following message:
    The AJAX request has Failed, Please try again;
    The unexpected data was: …

    current
    line 31. if ( -1 == success ) {

    fix
    line 31. if ( -1 == success && r.responses[0].supplemental.revisions != undefined) {

    Plugin Author Dion Hulse

    (@dd32)

    Meta Developer

    14 years, 9 months ago

    Took a slightly different route to you, 2.1.1 will fix all the above issues, see [427911] for the fix.

Viewing 3 replies - 1 through 3 (of 3 total)

The topic ‘[Plugin: Revision Control] Small bug found & suggestion: version 2.1’ is closed to new replies.