[Plugin: Shortcodes Pro] "Uncaught SyntaxError" when name begins with number
-
Hello, this plugin is just awesome, but there are some little bugs :(.
1st bug I found:
There’s a minor bug that make the tinyMCE buttons disapear because of the generated javascript located in shortcodes-pro/inc/shortcodespro-edit-js.phpUncaught SyntaxError: Unexpected identifier
when shortcode name is a number or begin with a number:
I made a shortcode named 960gs (guess what I was about to do).
Javascript parser fails at line 153 of the generated javascript (may be different for you as it’s generated javascript).
Here is the line that fails:
tinymce.PluginManager.add('960gs', tinymce.plugins.960gs);With syntax highlight, I can see that the second 960 get another color (seen as a number or I don’t know).
You should consider writting it somewhere or just fix it because somme people won’t know why it’s not working if they try with a shortcode named with a number on the first try and they will delete the plugin!
Second bug:
Ordering buttons is not working properly on 3.4.1 with Chrome Browser (did not test with others, it doesn’t save state and I don’t really know why. I can reorder using the parameter in the shortcode edit page (setting row manually), but I can’t add any separator.When I move a button to an empty row, it saves the list, but they’re not showing in tinyMCE if they’re not in the first row (kind of weird).
Edit: Only the items in row 2 doesn’t show in tinyMCE 1, 3 and 4 shows fine (but still can’t reorder using that nice ui)
I hope you can fix this (but take your time)
This is a badass plugin, seriously, I made some shortcode and the result is the same as those templates that provide some shortcode, it’s even better and it’s not theme dependant! Wonderfull, saves me so much time.
The topic ‘[Plugin: Shortcodes Pro] "Uncaught SyntaxError" when name begins with number’ is closed to new replies.