Hello @chgruver and @blockmonkey,
What version of PHP are you using?
Will have a code fix available soon regardless of version, but I want to confirm this is an error with specific versions.
Thanks,
Angelo
Hello @blockmonkey,
Oh that may make sense. You are using an older version of WordPress I assume?
Until we get this fixed, please downgrade to the previous branch: https://downloads.wp.xz.cn/plugin/powerpress.7.4.4.zip
@chgruver, are you also running a PHP version older than 5.6?
Thanks,
Angelo
@amandato thx for getting back to me so quickly. Yeah older WP as well.
We will looking into Downgrading the Plugin – until the fix has been implemented.
-
This reply was modified 6 years, 10 months ago by
blockmonkey.
Yes, I am running 5.4 also. I had already downgraded. Kind of wish my hosting company would hurry up and get their servers upgraded as it is more than likely a security issue not being able to update WordPress.
This isn’t due to the version of php, this is a clear Syntax Error.
To anyone wanting a quick fix, change line 712 to:
if(!empty($Feed[‘itunes_cat_’.$i]) && empty($Feed[‘apple_cat_’.$i])) {
The first empty() call had its closing parenthesis at the end of the statement and not where it should be – before the &&.
If newer versions of PHP don’t flag this as a syntax error, then at the very least the code will not do what you’d expect in this case.
To the author, please set up continous integration that runs syntax checking against the code before doing releases – a lot of people have automatic updates and their whole site breaks as a result.
Hello @thomasvs,
We are aware of the syntax error as noted in this thread, we are going to fix it for sure, again as noted. I wanted to confirm which versions this was failing for, as we tested with PHP 5.6, 7, 7.1, 7.2 and 7.3, but we did not test older versions of PHP. The logic does work interestingly, but it is also poorly written and as noted does not work for older versions of PHP. Another release will be made today to fix this.
Thanks,
Angelo
@thomasvs – That worked, thanks!!
