Plugin update to 2.1.6 causes content issues

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Support jaysupport

    (@jaysupport)

    4 years, 4 months ago

    Hi create,

    Garbage?.. I see code. So, for the first one, those are tags for commenting out code in CSS. And, for the second one, that is CSS that is being output by the shortcode. You can see the accordion is working fine, so it’s being rendered, just not the CSS that it’s also outputting.

    If you look at the changelog for the plugin, you will see that the recent updates added extra escaping to increase the security of the plugin. This was done at the request of WordPress following the temporary closure late last year. This is why the CSS is being escaped (instead of rendered) in your FAQ output.

    We’ll have a look to see if we can safely add that kind of CSS to the allowed output and, if so, we’ll release an update with the changes.

    Thanks for reporting this!

    • This reply was modified 4 years, 4 months ago by jaysupport.
    • This reply was modified 4 years, 4 months ago by jaysupport.
    Plugin Support jaysupport

    (@jaysupport)

    4 years, 4 months ago

    Hi create,

    We’ve just released a plugin update (version 2.1.7) that includes a new filter that lets you specify allowed tags for the FAQ answer/body. The filter is called ewd_ufaq_kses_allowed_html and we’ve provided an example of how to use it here: https://pastebin.com/ehrKmqK0

    This specific example shows how to allow the style tag (which would allow the CSS from the shortcodes you are using) and also how to allow specific attributes in other tags. You can remove the other tags, if you do not require those.

    Thread Starter create2thrive

    (@create2thrive)

    4 years, 4 months ago

    Hello,

    Thank you. 2.1.7 has fixed all but one issue we are seeing where a lightbox isn’t working because the content of a script tag isn’t being passed through (we think it should be passed since we set value to true in the php, but perhaps it is a different tag?).

    The expected html source (what we see from 2.0.24 and when it is not inside an FAQ such as this: https://www-dev.patterngenius.com/lightbox-page/):
    <script type=”text/javascript” charset=”utf-8″>
    /* <![CDATA[ */
    jQuery(document).ready(function($){
    $(function(){
    $(“a[rel=wplu_extpagewplu61f0b2c230ffb]”).fancybox({
    type : ‘iframe’,
    padding : 10,
    maxWidth : 640,
    maxHeight : 640,
    width : ‘95%’,
    height : ‘95%’
    });
    });
    });
    /* ]]> */
    </script>

    The html source we get when it is inside an FAQ (https://www-dev.patterngenius.com/ufaqs/lightbox-inside-faq/):
    <script type=”text/javascript” charset=”utf-8″>
    /* */
    </script>

    The functions.php code we are using is:
    add_filter( ‘ewd_ufaq_kses_allowed_html’, ‘allow_faq_content_tags’ );
    function allow_faq_content_tags( $tags ) {
    $tags[‘style’] = array();
    $tags[‘script’] = array(
    ‘type’ => true,
    ‘charset’ => true,
    ‘value’ => true
    );

    return $tags;
    }

Viewing 3 replies - 1 through 3 (of 3 total)

The topic ‘Plugin update to 2.1.6 causes content issues’ is closed to new replies.