• Resolved trevorwood

    (@trevorwood)


    I think there’s a possible false positive. Could you confirm please

    Files suggested are from the SendPress plugin

    ../httpdocs/wp-content/plugins/sendpress/classes/public-views/class-sendpress-public-view-open.php
    and
    …/httpdocs/wp-content/plugins/sendpress/inc/pages/default-public.php

    the lines flagged are

    //include(SENDPRESS_PATH . ‘img/clear.gif’);
    include(SENDPRESS_PATH. ‘/im/clear.gif’);

    https://ww.wp.xz.cn/plugins/gotmls/

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Author Eli

    (@scheeeli)

    An image file should never be rendered using the include function because it can result in executing PHP code hidden inside the image file. I just checked that plugin and they have rem’d out the include function and replaced that code with the file_get_contents function, which would be a better way to handle the image file.

    The second file mentioned has not been fixed. It too should be changed to use the file_get_contents function or passthru to render this image without interpreting PHP code.

    Thread Starter trevorwood

    (@trevorwood)

    That’s tru e- but the search still showed the rem’d out code as a problem

    Plugin Author Eli

    (@scheeeli)

    My plugin finds threat in the code even if it is rem’d out. That old code can be removed from the file without effecting the functionality of the plugin.

    The other usage that is not rem’d out should be changed. I have notified the plugin developers of this security vulnerability.

    Aloha, Eli

    Thread Starter trevorwood

    (@trevorwood)

    Thanks Eli – I guess they’ll fix it ITNR

    Plugin Author Eli

    (@scheeeli)

    Yeah, they took out that second file in the release they just rolled out. Since the code in that first file was already rem’d out it doesn’t matter if you leave it or remove it.

    Aloha, Eli

Viewing 5 replies - 1 through 5 (of 5 total)

The topic ‘Possible false positive’ is closed to new replies.