Possibly Incompatible with Heartbeat Control

  • Lee Hodson (VR51)

    (@leehodson)


    9 years, 7 months ago

    Hi,

    Installed Tailor into another site today. The Tailor page editor will not load when the Heartbeat Control plugin is active. The problem persists regardless of the active theme. Tailor works fine when the other plugins that are installed in the site are active.

    Console showed a couple of errors. Have forgotten what they were. Think they related to incorrect types being selected (referenced in the Tailor JS files). Maybe Tailor loads its JS files too soon (or too late, lol) for Heartbeat and Tailor to work nicely together.

    Might retest later in a clean environment with just Heartbeat Control and Tailor active. If I do retest I will grab those errors for you.

    Oh, when I say Tailor would not load I mean the resources begin to load into the page but the page remains blank and the loading gif stays on screen. The site logo link can be clicked, although it is hidden behind the Tailor loading screen so cannot be seen.

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author Andrew Worsfold

    (@andrewworsfold)

    9 years, 7 months ago

    Hi Lee,

    I’ve taken a quick look and the reason appears to be that Tailor has the WordPress ‘wp-auth-check’ script as a dependency for the “sidebar” app for authentication (which, in turn, is dependent on ‘heartbeat’ script). The sidebar app therefore doesn’t initialize, which causes errors to be displayed from the “canvas” side, as you’d expect.

    I’m guessing, like me, you’re getting the issue when you disable the heartbeat script completely. The plugin simply deregisters the heartbeat script completely, which appears (to me at least) to be a bit dangerous.

    The authentication side of things is pretty important for Tailor, and while it may be possible to workaround this I’m not sure that’s the best approach here. Perhaps someone with more knowledge of the heartbeat functionality could advise whether simply deregistering a core script is good practice and what, if anything, should be done about it.

    Cheers,
    Andrew.

    Thread Starter Lee Hodson (VR51)

    (@leehodson)

    9 years, 7 months ago

    Thank you for your reply, Andrew. I will reach out to the developer of the Heartbeat plugin. Maybe Heartbeat needs to be modified. Will let you know what happens.

    Jeff Matson

    (@jeffmatson)

    9 years, 7 months ago

    From a security standpoint, deregistering the heartbeat isn’t an issue at all. The only thing I can think of security-related is that heartbeat checks to see if the admin session is still valid, and prompts for login if invalid, but doesn’t actually affect that session if it’s disabled.

    Heartbeat Control is in desperate need of an update, and I’ve been toying with a few new things as well as a complete rewrite lately. It doesn’t surprise me much that it causes issues with a few things, as I haven’t updated it in quite a while.

    If you need any hooks or anything to fix the issue, let me know. Otherwise, I’ll take a peek to see what I can find whenever I get around to rolling out this update.

    Jeff

Viewing 3 replies - 1 through 3 (of 3 total)

The topic ‘Possibly Incompatible with Heartbeat Control’ is closed to new replies.