Preload google fonts “,,”

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Gabe Livan

    (@gabelivan)

    6 years, 8 months ago

    @alriksson not at all, there have been tests to make sure there won’t be situations like that. Perhaps, in some cases, it still does show depending on the Google URL fonts. Can you share the URL to your website so I can have a quick look? Or you can send it to me on private via https://gabelivan.com/contact/

    Thread Starter Rookie

    (@alriksson)

    6 years, 7 months ago

    I did not really look if it causes any issues or warnings when sending the comment. I just thought it did not look 100% alright. But looked a bit and from what I can see it should not be an issue.

    But why is it “,,”?

    Plugin Author Gabe Livan

    (@gabelivan)

    6 years, 7 months ago

    @alriksson You’re seeing ,, because that’s how the original LINK tags are having the SRC values. Here’s an example:

    Link #1:
    <link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Georgia:,300italic,400italic,,600italic,400,">

    LINK #2:
    <link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Inconsolata:40,700italic">

    The final combined link will be:

    Final Link:
    <link rel="stylesheet" id="wpacu-combined-google-fonts-css" href="https://fonts.googleapis.com/css?family=Georgia:,300italic,400italic,,600italic,400,|Inconsolata:40,700italic">

    The “mistake” (user/developer input) is kept in the combined tag. However, in future versions of Asset CleanUp, this will be automatically fixed and the font weights sorted in alphabetical order for easier reading (e.g. from ,,700,,400 to 400,700).

    • This reply was modified 6 years, 7 months ago by Gabe Livan.
    Thread Starter Rookie

    (@alriksson)

    6 years, 7 months ago

    Okay, gotcha! Many thanks, Gabe, make sense to clean this as well! 😉

Viewing 4 replies - 1 through 4 (of 4 total)

The topic ‘Preload google fonts “,,”’ is closed to new replies.