problem with attachment meta-data

jnz31
(@jnz31)

10 years, 7 months ago
hi.
thanks for this plugin, i do plenty wordpress-installs and this tool is a mandatory one. really handy.

i do have a problem though..
i imported some products via wp all import and with it some images. all worked fine, except some images sizes were not created. but whatever, using your tool should fix my problem, right? well, the images were created, but the meta-data was missing some entries in the sizes array. guess wp changed some of its behaviors during the last updates (>4.2).
here is what wp does:
```
[sizes] => Array
        (
            [thumbnail] => Array
                (
                    [file] => 252055201-150x150.jpg
                    [width] => 150
                    [height] => 150
                    [mime-type] => image/jpeg
                    [path] => 2015/09/252055201-150x150.jpg
                    [url] => example.com/252055201-150x150.jpg
                )
...
```
and here is, what your created meta-data looks like:
```
[sizes] => Array
        (
            [thumbnail] => Array
                (
                    [file] => 252012401-150x150.jpg
                    [width] => 150
                    [height] => 150
                    [mime-type] => image/jpeg
                )
...
```
you can see, that path and url is missing. now the url part is not correct eather, guess that is a bug in wp, but the path is correct and luckily i can work with that. well, if it exists..

let me see, what i can do, but i would be more than happy, when you jump in and help, since this is your baby and nobody knows it better than you..

https://ww.wp.xz.cn/plugins/ajax-thumbnail-rebuild/

Viewing 3 replies - 1 through 3 (of 3 total)

Thread Starter

(@jnz31)

ok. found the problem.
while image_get_intermediate_size returns all required meta-data (even with perfectly correct ‘url’ value), image_make_intermediate_size doesn’t. the second one only returns the values, that are shown in my previous post aka. file, width, height & mime-type. tried to solve this, but ran out of corrupt images, so i can’t find a way to test this properly.

could this work..?
if image_make_intermediate_size create an array $repeat and redo the function (cause now we do have all values to use image_get_intermediate_size)..?

function wp_generate_attachment_metadata_custom( $attachment_id, $file, $thumbnails = NULL ) {
	$attachment = get_post( $attachment_id );

	$metadata = array();
	if ( preg_match('!^image/!', get_post_mime_type( $attachment )) && file_is_displayable_image($file) ) {
		$imagesize = getimagesize( $file );
		$metadata['width'] = $imagesize[0];
		$metadata['height'] = $imagesize[1];
		list($uwidth, $uheight) = wp_constrain_dimensions($metadata['width'], $metadata['height'], 128, 96);
		$metadata['hwstring_small'] = "height='$uheight' width='$uwidth'";

		// Make the file path relative to the upload dir
		$metadata['file'] = _wp_relative_upload_path($file);

		$sizes = ajax_thumbnail_rebuild_get_sizes();
		$sizes = apply_filters( 'intermediate_image_sizes_advanced', $sizes );

		foreach ($sizes as $size => $size_data ) {
			if( isset( $thumbnails ) && !in_array( $size, $thumbnails ))
				$intermediate_size = image_get_intermediate_size( $attachment_id, $size_data['name'] );
			else
				$intermediate_size = image_make_intermediate_size( $file, $size_data['width'], $size_data['height'], $size_data['crop'] );
				$repeat = array( $attachment_id, $file, $thumbnails );

			if ($intermediate_size)
				$metadata['sizes'][$size] = $intermediate_size;
		}

		// fetch additional metadata from exif/iptc
		$image_meta = wp_read_image_metadata( $file );
		if ( $image_meta )
			$metadata['image_meta'] = $image_meta;

	}

	return apply_filters( 'wp_generate_attachment_metadata', $metadata, $attachment_id );
	if ( $repeat )
		wp_generate_attachment_metadata_custom( $repeat[0], $repeat[1], $repeat[2] );
}

Thread Starter

jnz31

(@jnz31)

10 years, 7 months ago

or maybe like so?? i’m not a hardcore php dev guy, but this one could work, too:
(if image_make_intermediate_size set meta, breakout and repeat)

removed, since it caused server error 500..

Thread Starter

jnz31

(@jnz31)

10 years, 7 months ago

nope. all of the above is crap, but this one works for me:
make_meta and than grab the rest and add it to the meta array. not very beautiful, but a working start..

function wp_generate_attachment_metadata_custom( $attachment_id, $file, $thumbnails = NULL ) {
	$attachment = get_post( $attachment_id );

	$metadata = array();
	if ( preg_match('!^image/!', get_post_mime_type( $attachment )) && file_is_displayable_image($file) ) {
		$imagesize = getimagesize( $file );
		$metadata['width'] = $imagesize[0];
		$metadata['height'] = $imagesize[1];
		list($uwidth, $uheight) = wp_constrain_dimensions($metadata['width'], $metadata['height'], 128, 96);
		$metadata['hwstring_small'] = "height='$uheight' width='$uwidth'";

		// Make the file path relative to the upload dir
		$metadata['file'] = _wp_relative_upload_path($file);

		$sizes = ajax_thumbnail_rebuild_get_sizes();
		$sizes = apply_filters( 'intermediate_image_sizes_advanced', $sizes );

		foreach ($sizes as $size => $size_data ) {
			if( isset( $thumbnails ) && !in_array( $size, $thumbnails )) :
				$intermediate_size = image_get_intermediate_size( $attachment_id, $size_data['name'] );
			else :
				$intermediate_size = image_make_intermediate_size( $file, $size_data['width'], $size_data['height'], $size_data['crop'] );
				$intermediate_meta = image_get_intermediate_size( $attachment_id, $size_data['name'] );
			endif;

			if ( $intermediate_size && $intermediate_meta ) :
				$metadata['sizes'][$size] = $intermediate_size;
				$metadata['sizes'][$size]['path'] = $intermediate_meta['path'];
				$metadata['sizes'][$size]['url'] = $intermediate_meta['url'];
			elseif ($intermediate_size) :
				$metadata['sizes'][$size] = $intermediate_size;
			endif;
		}

		// fetch additional metadata from exif/iptc
		$image_meta = wp_read_image_metadata( $file );
		if ( $image_meta )
			$metadata['image_meta'] = $image_meta;

	}

	return apply_filters( 'wp_generate_attachment_metadata', $metadata, $attachment_id );
}

Viewing 3 replies - 1 through 3 (of 3 total)

The topic ‘problem with attachment meta-data’ is closed to new replies.