Problem with pagination

Resolved greathemes
(@greathemes)

6 years, 1 month ago
Hello 🙂 Very nice plugin, but I have a problem with pagination. My customer uses a themify-shoppe theme and he didn’t update things from very long time. Now he wants to do that and after update WP, Woo and plugins I have a problem. Pagination doesn’t refresh and doesn’t work properly, just check it please (bravenew.hekko24.pl/inutri/shop-test).

What I can say (maybe it will help) that before update I used version 1.1.7 and everything worked as expected.

So now I’m not sure if it’s plugin-releated problem or theme-releated.

I’ve also reset Themify Settings to be sure that everything is default, I only changed pagination setting on Standard Pagination (numbers), not Infinite Scroll (this has also the same error by the way).

Some info about version:
– Themify Shoppe: 1.8.9.
– WordPress: 5.4 (I’ve also checked it on 5.0, 5.1, 5.2 and 5.3 versions, still the same problem).
– WooCommerce: 4.0.1 (I’ve also checked it on 3.7 version, still the same problem).

I have only 2 plugins activated, WooCommerce and Themify – WooCommerce Product Filter

Thanks in advance for your help.
- This topic was modified 6 years, 1 month ago by greathemes.
The page I need help with: [log in to see the link]

Viewing 13 replies - 1 through 13 (of 13 total)

Plugin Author themifyme
(@themifyme)

6 years, 1 month ago
Hi,

It seems to be working: https://share.getcloudapp.com/12uyyrnO. Since you are using a premium Themify theme, feel free to post the support tickets on https://themify.me/forum. Our support team will assist you.
- This reply was modified 6 years, 1 month ago by themifyme.
Primoz Cigler
(@cyman)

6 years, 1 month ago
Hey @themifyme,

Many our customers are reporting the same problem.

The bug was introduced with the very recent update of the plugin from 1.2.5 to 1.2.6. In file public/js/wpf-public.js around line 170 you have replaced $container.html(resp); which correctly included the pagination links with the following code:
```
products = $( resp ).find( '.product' );
var $productsContainer = $container.hasClass( 'products' ) ? $container : $( '.products', $container );
$productsContainer.empty().append( products );
```
which replaces only the products, but not pagination and product count above the products. The problem can also be seen on http://bravenew.hekko24.pl/inutri/shop-test/ if you select category with only a few products – you will see that the pagination and product count is not updated. Screenshot of the problem.

It is apparent to me that you made that change in the code to support Divi and Elementor, but broke the functionality of the regular WooCommerce users.

Proposed solution: revert to the previous behavior and do the extra check for the Elementor/Divi containers if these plugin need different handling. Moreover, in this line $.event.trigger('wpf_ajax_success'); around line 206 please add the response data with the custom trigger, like so $.event.trigger('wpf_ajax_success', { response: resp }); so the theme authors can get the rest of the data in the response and do further DOM changes and enhancements..
Plugin Author themifyme
(@themifyme)

6 years, 1 month ago

Will check with our developer on this.

Primoz Cigler
(@cyman)

6 years, 1 month ago

@themifyme great, update would be perfect otherwise I will be forced to fork your plugin and provide fixed version to our theme users.

Plugin Author themifyme
(@themifyme)

6 years, 1 month ago

@cyman We will fix it at our end and release an update early next week. Thanks for flagging this to us.

Primoz Cigler
(@cyman)

6 years, 1 month ago

Hey @themifyme, any updates? 🙂

Plugin Author themifyme
(@themifyme)

6 years, 1 month ago

That has been fixed. It is in testing phrase now.
vidhugoel
(@vidhugoel)

6 years ago
Hi @themifyme, I think I might be facing a similar issue. The pagination doesn’t work. I am using Astra theme and elementor. @cyman, it doesn’t work in elementor too.
The results count also don’t work which is very annoying. I tried using all three options of pagination, but they don’t work.

Please see to this issue. This is the url of the page I am working on, which has the product filter:
https://onmeindia.com/shop

Looking forward for some good fix to this issue.
- This reply was modified 6 years ago by vidhugoel.
Primoz Cigler
(@cyman)

6 years ago

@themifyme any update?
vidhugoel
(@vidhugoel)

6 years ago
Yes please @themifyme solve this issue.
I couldn’t bear with it so I removed the plugin from my site.
- This reply was modified 6 years ago by vidhugoel.
Plugin Author themifyme
(@themifyme)

6 years ago
We’ve released the update. Sorry for the inconvenience.
- This reply was modified 6 years ago by themifyme.
LunaGraphica
(@lunagraphica)

5 years, 9 months ago

We are running the latest version, but pagination is not showing up after we use the filter. We are not using Divi:

https://lgtest.com/gallery/

Any suggestions?

Plugin Author themifyme
(@themifyme)

5 years, 9 months ago

@lunagraphica – Please refer to the reply here: https://ww.wp.xz.cn/support/topic/pagination-not-working-175/#post-13336166