Problem with responsive layout

  • Resolved nrice

    (@nrice)


    8 years, 11 months ago

    Hi,

    Great plugin — simple & useful!

    Noticed a major issue though: page created using the ‘Blank Slate’ template doesn’t include some of the important HEAD tags (between META charset tag and first SCRIPT tag), namely:

    <meta name="viewport" content="width=device-width">
<link rel="profile" href="http://gmpg.org/xfn/11">
<link rel="pingback" href="http://www.some-website.com/xmlrpc.php">
<!--[if lt IE 9]>
<script src="http://www.some-website.com/wp-content/themes/some-theme/js/html5.js"></script>
<![endif]-->

    The missing META viewport tag causes the page to become non-responsive, so it doesn’t scale & display properly on mobile & tablet devices.

    We’ll appreciate a fix.

    Cheers 🙂

    Nick

Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Author Aaron Reimann

    (@areimann)

    8 years, 11 months ago

    I have a fix. Would prefer to test it a little before I make it an official update.

    Can you email me? I’ll shoot the updated plugin to you?

    Message me on Twitter (@areimann) so I can get your email address.

    Thread Starter nrice

    (@nrice)

    8 years, 11 months ago

    No worries. Just email me at [email protected]

    Plugin Author Aaron Reimann

    (@areimann)

    8 years, 11 months ago

    I sent you the code. We’ll have this in the repo shortly.

    Thread Starter nrice

    (@nrice)

    8 years, 11 months ago

    Thanks, got it.

    Thread Starter nrice

    (@nrice)

    8 years, 11 months ago

    Looks good!

    However, compared to the native WP template, the plugin template still doesn’t include two things:

    1. Pingback link header:

    <link rel="pingback" href="http://www.some-website.com/xmlrpc.php">

    2. HTML5 shim for IE8 & below (not important though):

    <!--[if lt IE 9]>
<script src="http://www.some-website.com/wp-content/themes/some-theme/js/html5.js"></script>
<![endif]-->

    Isn’t there a way to automatically/dynamically base the plugin template on the master theme template?

    Plugin Author Aaron Reimann

    (@areimann)

    8 years, 11 months ago

    There isn’t, per se, a way to have a master theme. The closest you get to a master theme would be a theme like twentyseventeen, but you can never assume that the theme even exists on the site.

    Also, twentyseventeen doesn’t have the pingback nor the shiv.js/css: https://themes.svn.ww.wp.xz.cn/twentyseventeen/1.3/header.php so I’d like to keep it as close to twentyseventeen as possible.

    Plugin Author Aaron Reimann

    (@areimann)

    8 years, 11 months ago

    Note, if you could give me a good review, it would be appreciated. Thanks!

Viewing 7 replies - 1 through 7 (of 7 total)

The topic ‘Problem with responsive layout’ is closed to new replies.