• Resolved Natali_Z

    (@natali_z)


    Please, correct the following errors:

    OMITTED TEXT DOMAIN
    
    1. .../codepress-admin-columns/codepress-admin-columns.php
    
    Line 295:
    So in the original -
    		array_unshift( $links, ac_helper()->html->link( AC()->admin()->get_link( 'settings' ), __( 'Settings' ) ) );
    So corrected -
    		array_unshift( $links, ac_helper()->html->link( AC()->admin()->get_link( 'settings' ), __( 'Settings', 'codepress-admin-columns' ) ) );
    
    Further only the corrected version.
    
    Line 339:
    		$groups->register_group( 'plugin', __( 'Plugins', 'codepress-admin-columns' ), 20 );
    
    Lines 498-501:
    		$groups->register_group( 'user', __( 'Users', 'codepress-admin-columns' ) );
    		$groups->register_group( 'media', __( 'Media', 'codepress-admin-columns' ) );
    		$groups->register_group( 'comment', __( 'Comments', 'codepress-admin-columns' ) );
    		$groups->register_group( 'link', __( 'Links', 'codepress-admin-columns' ), 15 );
    
    2. .../codepress-admin-columns/classes/Admin/Page/Addons.php
    Line 120:
    		AC()->notice( sprintf( __( '%s could not be activated.', 'codepress-admin-columns' ), '<strong>' . $plugin->get_name() . '</strong>' ) . ' ' . sprintf( 'Please visit the %s page.', ac_helper()->html->link( admin_url( 'plugins.php' ), strtolower( __( 'Plugins', 'codepress-admin-columns' ) ) ) ), 'error' );
    

    Other similar errors (22 pieces) and one typo – in the file, which you can download here:
    https://yadi.sk/d/B4wghxOB3NxegB

    And the last one. I propose to replace the Admin Columns on Columns (line 24 …/codepress-admin-columns/classes/Admin/Page/Columns.php). I (and many other translators) prefer to leave the original plugin name. Since in our case the plugin name matches the name of the tab, it turns uncomfortable:

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author Stefan van den Dungen Gronovius

    (@dungengronovius)

    Hi Natali,

    First of all, thank you very much for your effort in translating our plugin and for making this document for us. This is much appreciated!

    I had a look at each line in your document and added our text domain where necessary. But there are some strings and contexts where we like to use the default WordPress translation instead of our our own translation.

    For example the following translations are used in the same context as in WordPress: ‘Users’, ‘Media’, ‘Comments’, ‘Plugins’, ‘Yes’, etc

    I believe it is good practice to use these translations if they are available in WordPress core, especially because I think the translations for WordPress is more complete than the translation for our plugin.

    So I left those specific translations for what they are right now, but I’m curious on how you think about this manner.

    The changes will be available in our upcoming release. Thanks again for your input!

    Thread Starter Natali_Z

    (@natali_z)

    Well, let’s see what the result is. Because the rows without textdomain remained untranslated everyone, including those where, in theory, should have worked his own translation of WordPress. I have translated in accordance with the standard translation.

    I imported translation file here:
    https://translate.ww.wp.xz.cn/projects/wp-plugins/codepress-admin-columns/stable/ru/default
    Someone has to approve. Or give me editor rights, I’ll watch for updates of the plugin and make the desired changes.

    Plugin Author Stefan van den Dungen Gronovius

    (@dungengronovius)

    Hi Natali,

    Thanks again for your feedback.
    I believe someone from the Russian community has to approve your translation since we cannot approve it.

    Thread Starter Natali_Z

    (@natali_z)

    @sergeybiryukov, не поможете?

    Moderator Yui

    (@fierevere)

    永子

    @natali_z

    посмотрела, поставила вам права PTE на плагин, т.к. работы там еще хватит,
    спасибо )

    Thread Starter Natali_Z

    (@natali_z)

    Спасибочки. )

Viewing 6 replies - 1 through 6 (of 6 total)

The topic ‘Problems with the translation’ is closed to new replies.