“Product” before attribute name, new bug

  • Dima Stefantsov

    (@dima-stefantsov)


    9 years, 2 months ago

    https://ww.wp.xz.cn/support/topic/product-prepending-to-attribute-name-now/

    Same issue here: “Product” is prepended to attributes names. It happens in default admin UI, in attribute archive breadcrumbs, in few page titles, in 3rd party plugins.

    Issue is here: $tax_object->labels->name; // now returns “Product AttributeName” instead of “AttributeName”.

    While you can fix all your places to use $tax_object->labels->singular_name; // which has original “AttributeName” please fix $tax_object->labels->name; // instead. It is used by 3rd party plugins, I don’t see a reason why you should change its default bahaviour and prepend some nonsense text, which is not even in my shop’s language.

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Contributor Mike Jolley

    (@mikejolley)

    9 years, 2 months ago

    Attributes belong to products. So a prefix is NOT nonsense. All other taxonomies have the same prefix. Product is translatable. This is not going to be changed in core.

    Thread Starter Dima Stefantsov

    (@dima-stefantsov)

    9 years, 2 months ago

    You have suddenly changed attributes behaviour. Why? Why now “attribute->name” returns not “AttributeName”, but something more? Is there a logic behind it?

    If you claim calling it “Product Attributename” is ok, why don’t you prepend your categories as “Product CategoryName”?

    here is wc breadcrumbs of Product Categories.


    here is wc breadcrumbs for product attribute.

    Why?

    Plugin Contributor Mike Jolley

    (@mikejolley)

    9 years, 2 months ago

    We do in the backend where labels are actually used.

Viewing 3 replies - 1 through 3 (of 3 total)

The topic ‘“Product” before attribute name, new bug’ is closed to new replies.