Provide default alt attribute value in noscript tag | ww.wp.xz.cn

Resolved ov3rfly
(@ov3rfly)

1 year ago

Suggestion for the noscript tag:

To avoid empty value in frontend html, provide a default e.g. alt="Thumbnail" if no alt can be determined from video data in wp-youtube-lyte.php at about line 315.

Viewing 7 replies - 1 through 7 (of 7 total)

Plugin Author Optimizing Matters
(@optimizingmatters)

1 year ago

So do you mean in the alt attribute of the <a href tag inside the noscript block?

Thread Starter ov3rfly
(@ov3rfly)

1 year ago

What else could I mean?

Plugin Author Optimizing Matters
(@optimizingmatters)

1 year ago

OK, should be fixed on the Github version, if you feel like it you can download the zip-file here and test the change 🙂
Thread Starter ov3rfly
(@ov3rfly)

1 year ago
Thanks for the quick fix.

You could also add translation possibility.
```
Now: 'alt="YouTube video thumbnail"'

Maybe: 'alt="' . esc_attr__( 'YouTube video thumbnail', 'wp-youtube-lyte' ) . '"'
```
Plugin Author Optimizing Matters
(@optimizingmatters)

11 months, 4 weeks ago

done 🙂

I’ll probably release the update on ww.wp.xz.cn soon-ish 😉

Thread Starter ov3rfly
(@ov3rfly)

11 months, 4 weeks ago

Thanks for the info. But note instead of your current __( ) the suggested esc_attr__( ) to escape translations which might contain a quote char or other invalid attribute values.

Plugin Author Optimizing Matters
(@optimizingmatters)

11 months, 3 weeks ago

done and released 🙂

Viewing 7 replies - 1 through 7 (of 7 total)

The topic ‘Provide default alt attribute value in noscript tag’ is closed to new replies.

Tags

7 replies
2 participants
Last reply from: Optimizing Matters
Last activity: 11 months, 3 weeks ago
Status: resolved