Redirect Loop if url parameter has multiple spaces

  • Resolved Roland

    (@rolandfarkas)


    4 years, 10 months ago

    Hey AMP-WP Devs,

    I have noticed that the AMP plugin causes a redirect loop if the url has more than one spaces as ” ” or “%20” or “+” or “_”.

    We have only noticed the issue this morning as WordPress was updated to the latest version.

    You can test this by adding the following to a url:

    “/?test=test this out as it breaks your site”

    or https://example.com/?test=test%20this%20out%20as%20it%20breaks%20your%20site

    As soon as I disable the amp plugin the issue goes away, first we thought it’s the template, but the issue can be re created with twentytwentyone etc. No other plugins were on the site and the issue still exists.

    Can you please take a look? If this is an issue with the amp plugin, can you roll out a patch? It broke some of my clients websites we use on google ads as we use UTM’s as well as other URL parameters for tracking.

    PS.; I only tested this on multiple different nginx servers and I have not tested it on Apache.

    Update: Tested on Multisite and Single instance and no difference

    Let me know if I can help with anything

    Thank you

    • This topic was modified 4 years, 10 months ago by Roland.
    • This topic was modified 4 years, 10 months ago by Roland.
    • This topic was modified 4 years, 10 months ago by Roland.
Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Support Milind More

    (@milindmore22)

    4 years, 10 months ago

    Hello @rolandfarkas

    Thank you for the support topics, I am unable to reproduce this issue with just twentytwentyone theme and the AMP plugin active.

    here is a test URL

    I doubt this may be mostly related to your server configurations, I will recommend contacting your hosting provider.

    Additionally, please share your site health information using this form so we can investigate the issue further.

    Plugin Author Weston Ruter

    (@westonruter)

    4 years, 10 months ago

    @rolandfarkas What template mode are you using? If transitional or reader, do you also have mobile redirection enabled?

    Thread Starter Roland

    (@rolandfarkas)

    4 years, 10 months ago

    Hey @milindmore22,

    I’ve tried this on 3 different nginx servers, I’ll spin up an apache server and test on that too. I haven’t had similar problems in the past and the latest WordPress update might have triggered the problem.

    My WP nginx cfg part isn’t much different to the basic one. I also tested on PHP 7.4 & 8.

    @westonruter I only use standard mode

    FYI A user commented on the re post of this issue on the amp slack showing his url and having the same problem

    Thread Starter Roland

    (@rolandfarkas)

    4 years, 10 months ago

    defeated-leopard.jurassic.ninja/?test=test+this+out+as+it+breaks+your+site

    I have uninstalled Jetpack, installed AMP, enabled standard mode, selected a static homepage, and changed the permalink settings to Post Name.

    So by the looks of it, a combination of the above settings is the cause.

    Plugin Support Milind More

    (@milindmore22)

    4 years, 10 months ago

    Hello @rolandfarkas

    Thanks for the input, Yes I am able to reproduce this issue when I choose the static homepage.

    Also thank you for creating a GitHub issue for the same.

    Plugin Author Weston Ruter

    (@westonruter)

    4 years, 10 months ago

    I’ll resolve this topic since we’ll now track it in GitHub.

Viewing 6 replies - 1 through 6 (of 6 total)

The topic ‘Redirect Loop if url parameter has multiple spaces’ is closed to new replies.