Rollback CSS adjustments

  • Resolved Ben

    (@benbornschein)


    2 years, 7 months ago

    View post on imgur.com

    With one of your latest updates, these settings are applied and causing massive trouble. In many cases, especially in the EU, YouTube videos, for example, are initially blocked and then unblocked with one click. Here is more than just an iframe in the container of “.ast-oembed-container” and due to your new settings, the design of these elements is destroyed.

Viewing 7 replies - 16 through 22 (of 22 total)
1 2
  • Thread Starter Ben

    (@benbornschein)

    2 years, 6 months ago

    The bug is not fixed, your oEmbed modification is still bugged and destroys the code that is returned. Only the CSS rule is fixed, but it’s still broken.

    Thread Starter Ben

    (@benbornschein)

    2 years, 6 months ago

    I have already informed Sudhanshu about the issue, please check if he received my mail.

    Herman Asrori (BSF)

    (@bsfherman)

    2 years, 5 months ago

    Hi Ben,

    Yes, he received your email, and our team is working on this.

    Thanks a lot for your cooperation and patience.

    Kind regards,
    Herman 😊

    Herman Asrori (BSF)

    (@bsfherman)

    2 years, 5 months ago

    Hi Ben,

    Just checking in to see if you can confirm that our V4.6.x we released recently fixes this issue.

    Please let us know.

    Kind regards,
    Herman 😊

    Thread Starter Ben

    (@benbornschein)

    2 years, 5 months ago

    It’s still not working and I have already written Sudhanshu.

    Thread Starter Ben

    (@benbornschein)

    2 years, 5 months ago

    We have investigated the reason for this strange behavior and found several problems. For example, in Astra_After_Setup_Theme::responsive_oembed_wrapper you call wp_oembed_get(), but the responsive_oembed_wrapper() function is called by WordPress and already contains the result of wp_oembed_get() – you call the result twice.

    Another problem is how you are trying to add your wrapper around the oEmbed code in Astra_Gutenberg::add_iframe_wrapper(). Your regex breaks the HTML code if more than one div container is part of $block_content.

    Since we’ve already waited three months for a solution to a problem you introduced in an update in October, we’ve added a compatibility patch for our plugin to work around the issues caused by Astra.

    Herman Asrori (BSF)

    (@bsfherman)

    2 years, 5 months ago

    Hi Ben,

    We’re sorry for the inconvenience.

    I’ve had a detailed discussion with our dedicated development team, and it appears that they’ve been swamped with tasks aligning with our internal roadmap, particularly with the Astra 4.6.0 Beta and Astra 4.6.0 that was major update.

    Anyway, thank you for sharing your finding and decided to add the compatibility patch to your plugin. In the future, if you face such a situation, feel free to contribute fixing the issue by raising a PR on our Astra GitHub.

    Last but not least, thanks for marking this thread as Resolved.

    Kind regards,
    Herman 😊

Viewing 7 replies - 16 through 22 (of 22 total)
1 2

The topic ‘Rollback CSS adjustments’ is closed to new replies.