Sanitization apparently completely breaks the plugin?

  • patrick1994

    (@patrick1994)


    4 months, 4 weeks ago

    I see my regex is stored sanitized (see the .%2A instead of .*) in the PREFIX_ultimate_410 table (see this SQL dump):

    LOCK TABLES wp_ultimate_410 WRITE;
    /*!40000 ALTER TABLE wp_ultimate_410 DISABLE KEYS */;
    INSERT INTO wp_ultimate_410 VALUES
    ...
    (3,'~something/.%2A~i',1),
    /*!40000 ALTER TABLE wp_ultimate_410 ENABLE KEYS */;
    UNLOCK TABLES;

    In the debugger, I see the rule tester uses the sanitized regex (again, with .%2A instead of .*), which is bound to fail.

    wp-content/plugins/ultimate-410/src/RuleTester.php line 19

            if ($this->regex) {
                return (bool)(preg_match($this->rule, $request) ?: preg_match($this->rule, urldecode($request)));
            }

    I have tested v1.1.4 since the 1.1.5 entry in the changelog mentions sanitization. 1.1.4 works. It seems you need to rewrite your plugin to store the regexes untouched and only sanitize for the options screen. Perhaps contact the patchstack guys for advice?

You must be logged in to reply to this topic.