script type=”text/javascript” not necessary with html5

  • Resolved winterfjell

    (@winterfjell)


    2 years ago

    Hello Frank,
    you already know from my review that I am a big fan of youtube lyte.
    Now I noticed a warning in the w3c validator that the script type=‘text/javascript’ is not necessary for html5 because javscript is the default value. I removed in 3 lines in wp-youtube-lyte.php and in 1 line in options.php and the warning is gone. The website still works fine.

    Maybe you cosider about testing this customisation and include it in a next update? Or did I miss something important.

    Cheers Malte

Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Author Optimizing Matters

    (@optimizingmatters)

    2 years ago

    yes, it’s perfectly safe not to have that attribute and for a next release (no ETA I’m afraid) I’ll make sure they’re not output any more. that being said; there is no significant having the default value there even if the W3C validator flags it 😉

    Thread Starter winterfjell

    (@winterfjell)

    2 years ago

    Thanks for your quick reply. Since it is a warning and no error, there surely is no need to hurry. I mark thi topic as solved.

    Plugin Author Optimizing Matters

    (@optimizingmatters)

    1 year, 9 months ago

    just made a change on the github version, feel free to download the zip-file and take it out for a spin 😉

    best,
    frank

    Thread Starter winterfjell

    (@winterfjell)

    1 year, 9 months ago

    Thank you, I really appreciate your work! While the wp-youtube-lite.php looks “solved” the options.php still has one entry script type=‘text/javascript’ in line 349, if I get it right. And the version number in github 1.7.22 is to low compared to the official 1.7.23 in the WordPress plugin repository.

    Cheers, Malte

    Plugin Author Optimizing Matters

    (@optimizingmatters)

    1 year, 9 months ago

    stray type-attrib confirmed and eliminated from options.php and updated version number, can you have another look (would be esp. interested in confirmation the gutenberg alginment fixes in this version)? 🙂

    Thread Starter winterfjell

    (@winterfjell)

    1 year, 9 months ago

    Thank you, Frank! Both php files are working well with the w3c validator.

    Regarding your other question: Since I’ve deactivated the automatic embed/oembed feature of WordPress and insert every Youtube video as html block, I’m not sure, if I can be of great help. On the front end everything looks fine though.

    Plugin Author Optimizing Matters

    (@optimizingmatters)

    1 year, 9 months ago

    thanks for the feedback 🙂

Viewing 7 replies - 1 through 7 (of 7 total)

The topic ‘script type=”text/javascript” not necessary with html5’ is closed to new replies.