Several Plugin Conflicts with new update

  • Matt Hodder

    (@matthodder)


    3 years, 11 months ago

    I have found a couple issues with two plugins I have installed when updating to the 3.0.x version of LH Archived Status plugin.

    1. Missing “Copy to a new draft” link on Classic editor views with the Yoast Duplicate Post plugin. This hooks into the ‘post_submitbox_start’ action and the link displays right above the “Move to Trash” link in #major-publishing-actions div. I found I was able to resolve the issue by editing line 715 of wp-statuses/inc/admin/classes/class-wp-statuses-admin.php changing do_action( 'post_submitbox_start'); to do_action( 'post_submitbox_start', $post ); Hoping that this fix can be added to the plugin on future update.

    2. Missing text and buttons with the PublishPress Revisions plugin. A “New Revision” button is supposed to appear in the #major-publishing-actions div above “Move to Trash” link. When I enable this plugin it doesn’t appear in either Classic or Block view.

    2b. Also, a “New Revision” text link should appear under the quick actions on /wp-admin/edit.php?post_type=page pages. The link is there but the text doesn’t appear for some reason. This is resolved when I disable LH Archived Status.

    EDIT: I believe the PublishPress Revisions issues seem to be related to the global $wp_post_statuses object changing structure. The $wp_post_statuses->[status]->labels changes from an object in default WordPress to an Array when LH Archived plugin is enabled.

    • This topic was modified 3 years, 11 months ago by Matt Hodder.
    • This topic was modified 3 years, 11 months ago by Matt Hodder.
Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Author shawfactor

    (@shawfactor)

    3 years, 11 months ago

    Thankyou

    I’ll incorporate the fix to the first issue shortly, and have already raised the issue on GitHub for the wp statuses library which handles this side of the functionality

    I’ll have to look at the other issues in more details and run some testing.

    Pete

    Plugin Author shawfactor

    (@shawfactor)

    3 years, 11 months ago

    I’m on this but am travelling atm and don’t have a laptop or svn. In two weeks I’ll be back in my office and will sort the first issue and look at the second

    Plugin Author shawfactor

    (@shawfactor)

    3 years, 10 months ago

    Thie first of these two issues should be resolved with et new version (Ive liaised with imath and the wp statuses library now incorporates do_action( ‘post_submitbox_start’, $post );

    I’ll immeidately look at issue two

    Plugin Author shawfactor

    (@shawfactor)

    3 years, 10 months ago

    @matthodder The second issue is not to do with it being an array rather than an object (they both objects, although the type is different). Any other ideas? I do not use publishpress and am not keen to test its just to get it be compatible. But i will obviously fix anything that is not working right and or is non standard

    Thread Starter Matt Hodder

    (@matthodder)

    3 years, 7 months ago

    The issue is that both plugins are registering $wp_post_statuses[labels] values but doing it differently and that is causing the conflict. Publishpress registers it as an object and your plugin (or the wp-statuses library) registers it as an array. See the code side by side.

    I’ll check with PublishPress Revisions since it’s probably easier to fix/account for on their end. Other then that, I guess I’ll just keep patching it.

    • This reply was modified 3 years, 7 months ago by Matt Hodder.
    • This reply was modified 3 years, 7 months ago by Matt Hodder.
    Plugin Author shawfactor

    (@shawfactor)

    3 years, 7 months ago

    @matthodder
    Thanks for the clarification

    I’ve not done the analysis but I was wondering what way is most consistent with how core WordPress does this? Logically we should have consistency don’t you think…

    • This reply was modified 3 years, 7 months ago by shawfactor.
    Plugin Author shawfactor

    (@shawfactor)

    3 years, 7 months ago

    Actually I’ve done this analysis and IMo the issue lies with publishpress. In a blank WordPress install the post statuses are all objects but everything blow that is an array or arrays.

    I’lve added an issue to publishpress to their forum on the repository.

    • This reply was modified 3 years, 7 months ago by shawfactor.
    Plugin Author shawfactor

    (@shawfactor)

    3 years, 7 months ago

    The publishpress guys have added this as an issue on GitHub. Hopefully they fix it at their end

Viewing 8 replies - 1 through 8 (of 8 total)

The topic ‘Several Plugin Conflicts with new update’ is closed to new replies.