• Resolved smeiers-kue

    (@smeiers-kue)


    I have the Sharing Buttons active on a website that we are in the middle of putting together, and I have Facebook, Twitter, Google+, Print, Email buttons selected. I’ve chosen the Icon Only view. In the Sharing settings, the preview shows the icons correctly and they look good there. When I go to the website, the Facebook and Twitter icons don’t show up right. I’m running the latest version of wordpress and jetpack, Using the Franklin Child Theme. Any ideas?

    http://everonwardkue.org/?page_id=108

    thanks,
    Sarah

    https://ww.wp.xz.cn/plugins/jetpack/

Viewing 9 replies - 1 through 9 (of 9 total)
  • Plugin Contributor George Stephanis

    (@georgestephanis)

    Just to rule things out, can you add the following line temporarily to your wp-config.php file?

    define( 'SCRIPT_DEBUG', true ); — right before the line that says something about define( 'WP_DEBUG' ...

    That alone may resolve the symptoms of the issue for you, and if so, it’ll let us know where to look for a better fix.

    Thread Starter smeiers-kue

    (@smeiers-kue)

    Thanks for the suggestion. I added this line, and I don’t see a change.

    Plugin Contributor George Stephanis

    (@georgestephanis)

    Okay, that may have not cured the issue, but it did let me get some better diagnostic data.

    It looks like the theme you’re using — Franklin, from ThemeForest vendor Studio 164a — is bundling some code in it called sharrre that is messing with the sharing buttons markup.

    It looks like it’s rewriting the Facebook and Twitter markup that looks something like this originally:

    <li class="share-facebook"><a rel="nofollow" data-shared="sharing-facebook-108" class="share-facebook sd-button share-icon no-text" href="http://everonwardkue.org/?page_id=108&share=facebook" target="_blank" title="Share on Facebook"><span></span><span class="sharing-screen-reader-text">Share on Facebook (Opens in new window)</span></a></li><li class="share-twitter"><a rel="nofollow" data-shared="sharing-twitter-108" class="share-twitter sd-button share-icon no-text" href="http://everonwardkue.org/?page_id=108&share=twitter" target="_blank" title="Click to share on Twitter"><span></span><span class="sharing-screen-reader-text">Click to share on Twitter (Opens in new window)</span></a></li>

    To look something like this instead:

    <li class="share-facebook sharrre"><div class="box"><a class="count" href="#">0</a></div></li><li class="share-twitter sharrre"><div class="box"><a class="count" href="#">0</a></div></li>

    You can see all the missing markup. The added sharrre class makes me thing that sharrre which is bundled with your Franklin theme is mangling the buttons.

    I’m sending off a tweet to Studio 164a — the folks who built the theme in question — to see if they have any information as to the conflict, and if they’d be willing to comment or look into it.

    Plugin Contributor George Stephanis

    (@georgestephanis)

    It looks like it’s the Plugin.prototype.renderer method that’s overwriting the markup —

    /* render methode
      ================================================== */
      Plugin.prototype.renderer = function () {
        var total = this.options.total,
        template = this.options.template;
        if(this.options.shorterTotal === true){  //format number like 1.2k or 5M
          total = this.shorterTotal(total);
        }
    
        if(template !== ''){  //if there is a template
          template = template.replace('{total}', total);
          $(this.element).html(template);
        }
        else{ //template by defaults
          $(this.element).html(
                                '<div class="box"><a class="count" href="#">' + total + '</a>' +
                                (this.options.title !== '' ? '<a class="share" href="#">' + this.options.title + '</a>' : '') +
                                '</div>'
                              );
        }
      };

    in http://everonwardkue.org/wp-content/themes/franklin-wordpress-theme-1.6.2/franklin//media/js/jquery.sharrre-1.3.5.js?ver=1.6.1

    It’s a match to the <div class="box"><a class="count" href="#">0</a></div> markup that is overwriting the Jetpack Sharing markup.

    Thanks for the sleuthing George. I’ll see if there’s a way I can manage to retain Sharrre while still supporting Jetpack’s sharing markup, but otherwise I may have to switch to a different sharing library.

    Cheers,
    Eric

    Hi Sarah,

    I’m going to push out an update to Franklin today, which will solve this problem. Sorry about the hassle.

    Cheers,
    Eric

    Thread Starter smeiers-kue

    (@smeiers-kue)

    All – thanks for your diligence here! I appreciate all the help. I’ll go ahead and mark this as resolved and look for the update to the theme.

    Happy Holidays!
    Sarah

    I have the latest version of Franlin running, and I’m still having this problem.

    Could you please get in touch via our support form at https://164a.com/support?

    To help, you could you also send your EDD System Info report? Here’s how you can get that:

    • Log into your WordPress dashboard.
    • Go to Campaigns › Tools
    • Click on the System Info tab

    The information provided by this report is very helpful for us when we provide support to you. It does not include any sensitive details like passwords, email addresses, etc.

Viewing 9 replies - 1 through 9 (of 9 total)

The topic ‘Sharing button images do not show up’ is closed to new replies.