@lewisburgess79 – Sorry to hear that. Can you give me an idea of how you are using them? I ask because you mentioned “making new lines” was undesirable, I’m assuming you are using them inline with other text surrounding them?
I just want to be sure I’m solving for the right issue.
In any case I just checked the old and new and the only difference appears to be that we added an extra class. No new div, the div was always there.
So unless you have CSS on the page that targets those classes, or maybe some new theme CSS that makes all div render as blocks, nothing should have changed:
Hi,
I’ve linked to some screenshots which will hopefully show what’s happening (this is an Intranet site so isn’t accessible without a login).
End user view: https://ibb.co/s6JXvgW
Code view: https://ibb.co/D9066YL
Nimble editor visual view: https://ibb.co/L13jKVz (note I’ve turned off “Automatically convert text into paragraph”)
End user browser developer tools code of the area: https://ibb.co/5TRd1DK
In the End user view, you will see each item on a new line. They should be side-by-side without a paragraph/new line from a DIV.
Not sure if this is the theme or editor though?
Thanks for your help 🙂
Lewis
@lewisburgess79 – Curious, have you tried downgrading to v1.10 again? Not as a solution, but if it happens with that version too I’d have to assume it was in fact coming from theme or something else.
Honestly I can’t see how adding those 2 classes in the new version would change things, unless something in your theme also used those same classes before we did so. Otherwise if you also updated theme or other plugins recently that might be a good place to check as well.
That said, in your editor you wrap them with <p>, change that to a <div> and the html should be valid. Currently <div> can’t be inside a <p>, but our shortcode always used divs so I don’t think that was the only issue.
In the short term simple fix might just be some CSS.
.some-custom-parent-class .content-control-accessible {
display: inline; // you could try inline-block as well.
}
@lewisburgess79 – v2.0.9 had some changes to the custom message, both in how it is saved and rendered. Might be worth seeing if that helps resolve any issues.
Let me know.
@lewisburgess79 – If your still having issues feel free to mark this as unresolved again.
If not please take a moment to rate & review the plugin and or support to spread the word.
Sorry for the delay. I updated the plugin but saw no change in behaviour 🙁
@lewisburgess79 – Ok so I just set up a test using the following simple but effective blob of shortcode:
[content_control logged_out=1]Login[/content_control][content_control]Logout[/content_control][content_control logged_out=1]Login[/content_control][content_control]Logout[/content_control][content_control logged_out=1]Login[/content_control][content_control]Logout[/content_control][content_control logged_out=1]Login[/content_control][content_control]Logout[/content_control]
This results in
Logout
Logout
Logout
Logout
When I expect LogoutLogoutLogoutLogout etc.
That said I also tested this same code on v1.10.2, with the exact same results.
So it wasn’t different before, but I do see the need for this to work as intended.
We might have to add an inline parameter to it.
I do think you can get there today using the following.
[content_control logged_out=1 class="inline"]Content[/content_control]
Then add some CSS to your site of
.content-control-container.inline { display: inline; }
I have added this to our issue tracker. Gonna mark this resolved for now as its not a new bug and we need to think out a long term solution.
Please take a moment to rate & review the plugin and or support to spread the word.
-
This reply was modified 2 years, 8 months ago by
Daniel Iser.