@toengel – it looks like it’s stripping the CSS required to SAB to display properly. I’ll have a more in-depth look into this and release an update to address it.
Hi,
sounds great! Thanks for spending effords into fixing it!
Toengel@Alex
Hi @alex,
I’ve already found a fix for this and will release an update shortly.
Thanks,
Cristian.
Hi,
great!
BTW – in my debug log I have the following Notice:
[18-May-2018 14:44:43 UTC] PHP Notice: Trying to get property of non-object in /……./wp-content/plugins/simple-author-box/inc/class-simple-author-box.php on line 329
Maybe you can take a look at it, too…
Toengel@Alex
Hi @alex,
sure, I’ll fix this as well in our next update. Mind telling me which PHP version you’re running?
Thanks,
Cristian.
@alex,
version 2.0.7 (just released) should add AMP compatibility 🙂
Thanks,
Cristian.
Hi,
I just checked the new version. It’s better, but I have much empty space after each line in the AMP version… can you check the links in the first post again?
Thanks in advance,
Alex
Hi @alex,
yep, it’s a minor bug, will release an update today to address it. I basically forgot to add ‘px’ in custom CSS rule.
@alex – version 2.0.8, just released, should fix this issue.
Thanks,
Cristian.
Hi,
great – it’s working…
Another issue:
In the settings the social icons are set up to “colored”, but in AMP version they arn’t…
Also, I have a link in my profile description. Is it possible to underline them or use a “standard” color to differentiate between normal text?
Thanks,
Alex
Hi,
another issue: if I color the social links row, it’s not colored in AMP version…
Alex
Hi @alex,
1. colored icons don’t match up (and never will) in AMP. AMP needs custom CSS added by hand which is cumbersome, to say the least. Here’s the current CSS I’ve added (https://github.com/MachoThemes/simple-author-box/blob/master/inc/class-simple-author-box.php#L377-L491) which took about 1 full day of testing. This is the normal CSS that would need to be added: https://github.com/MachoThemes/simple-author-box/blob/master/assets/css/simple-author-box.css#L187-L1341. Please remember that one line in the regular CSS stylesheet equals one entry in the CSS AMP compatibility array
We’ll be releasing v2.0.9 that fixes the validation issues in about 10-15 minutes. I’ve already tested it and it looks like my AMP implementation was poor. Wasn’t aware of the validator and as long as everything loaded OK at my end, I thought I was donezo.
Thank you for your continued help @alex – highly appreciated!
Hi,
seems to work… great…
You should update your plugin description to include AMP – there are no really good plugins for author boxes with AMP support…
Toengel@Alex
