SimpleTOC doesn’t work well with GenerateBlocks
-
Since the Support Monitor here deleted my entries in the previous topics and told me to start my own for help I am doing that here with feedback from the GeneratePress Developers. Before you just mark this as a duplication and resolve it please read on. I’m trying to help you fix the problem. Your plugin is awesome, but I am having to move away from it to launch a website so hopefully you can fix this in the future for other people.
As stated in these other topics SImpleTOC has a problem that breaks GenerateBlocks Dynamic content.
- https://ww.wp.xz.cn/support/topic/post_permalink-not-working-anymore/
- https://ww.wp.xz.cn/support/topic/simpletoc-problem-with-generateblocks/
After reviewing the previous original topic and doing some research the Generate Block dev team reported these findings and made a suggestion for how you could fix it as I suspect this will break other plugins as well:
The ToC plugin uses PHP’s
DOMDocumentto parse and re-serialize the entire block HTML to addidattributes to headings.This happens before dynamic tags are processed and their data is rendered.
As a result, the HTML still contains GenerateBlocks dynamic tags with their curly braces. When these appear inside a URI attribute such as
href,DOMDocumentencodes them, making the tag unrecognisable by GenerateBlocks’ Dynamic Data engine.Unfortunately, we cannot change
DOMDocumentor the ToC plugin’s behaviour, making it incompatible with GB Dynamic Tags.More broadly; reprocessing the full HTML just to inject heading IDs is a bit heavy-handed. I would recommend that the developer investigate
WP_HTML_Tag_Processor, introduced in WordPress 6.2, which avoids these compatibility issues and is a better-suited method for the task.I hope this helps clarify the issue.
GeneratePress SupportI hope this helps and gives you what you need to move forward. Thank you for being a WordPress developer. Your plugin basically is breaking, dynamic buttons, pagination links etc. in the GeneratePress echo system. As of Version 6.9.6 I would recommend anyone building sites with GeneratePress and GenerateBlocks do not use this plugin. Hopefully this will be fixed in a future version.
Good luck to you. I’m off to remove your plugin from nearly 100 pages of two websites so I can launch them with working links.
-
Okay, i think I can replicate it. Is this the problem? Screenshot of the problem: https://ibb.co/Q7PsHJ3C
- I installed GenerateBlocks
- Added a Loop Query
- Inside the loop query are dynamic headlines like a template for the query as in wordpress core
- The whole loop appears in SimpleTOC as {{post_title link:post}}
- The content itself renders okay inside the post. Only the headline in SimpleTOC is “broken”.
I saw in your other topic you wanted to know how to duplicate this issue. and I just saw your example, but you can do something simpler because the problem is bigger than just in the loop. Since I didn’t want them to delete my reply again I’m adding the answer to my own topic. How to see the issue:
- Built a local site with GeneratePress theme (free version) and Generateblocks (free version)
- Installed SimpleTOC (current version 6.9.6)
- Built a page with TOC block and a few junk headers to make sure TOC was working
- Added in a Generateblocks button and added a dynamic link setting it to the post URL using the Dynamic Tag feature.
- Published the page and mouse over the button link and instead of saying the url it shows http://{{post_permalink}}/
- Disable SimpleTOC and the link because the correct one.
- A more complex option is to build a query using the Advanced Query and include pagination the previous and next buttons will not be the right URL but will be a code.
Hope this helps.
You must be logged in to reply to this topic.
