Some issues & suggestions

  • Resolved Ov3rfly

    (@ov3rfly)


    10 years, 9 months ago

    Some feedback after evaluating plugin 1.6.0 with WordPress 4.3:

    1. “Settings Updated” message is always shown in admin if a setting for ng_slicknav_menu is stored in options. It should only show after using “Update” button.

    2. “Menu Button Position” set to “left” does not work in combination with a logo. The logo also floats left so the button can’t go there.

    3. For “Stick Menu to Head” a higher z-index (currently 999) should be used. We tested with “Twenty Eleven” theme, it uses e.g. 9999 for it’s #branding header, would suggest at least 999999.

    4. Settings can be overwritten via CSRF, please use wp_nonce_field() and check_admin_referer() in backend, examples here.

    5. Would suggest an additional setting or using the search-form setting to switch off wp_enqueue_style( 'dashicons' ) in frontend, it is not required if no searchform is used in menu.

    6. Would suggest $data = apply_filters( 'ng_slicknav_php_vars', $data ); or similar before wp_localize_script(...) for advanced users. We had to add a filter there to be able to set different label/logos in different site-areas and to provide the label in different languages.

    Questions welcome, thanks for the great plugin.

    https://ww.wp.xz.cn/plugins/slicknav-mobile-menu/

Viewing 8 replies - 1 through 8 (of 8 total)
  • Thread Starter Ov3rfly

    (@ov3rfly)

    10 years, 9 months ago

    7. In file inc/options-page-wrapper.php line 317 the option value is "bold'" instead "bold". This causes font-weight: bold\&_#039;; instead of font-weight: bold; in CSS output and “Menu Label Weight” is always set back to “Normal” after saving.

    Thread Starter Ov3rfly

    (@ov3rfly)

    10 years, 9 months ago

    8. In CSS output one ; is missing in .slicknav_arrow rule, one ; is too much in .slicknav_icon-bar rule and several space chars between ?> and ; could be removed.

    Plugin Author neilgee

    (@neilgee)

    10 years, 9 months ago

    Thanks for the feedback, appreciated – will get these rolled into the next update.

    Plugin Author neilgee

    (@neilgee)

    10 years, 9 months ago

    All of these issues bar the filter are now in version 1.6.1, are you able to provide your filter usage so I can test.

    Thread Starter Ov3rfly

    (@ov3rfly)

    10 years, 9 months ago

    Here the changed version of 1.6.0 function scripts_styles() which we currently use, changes are marked with // Ov3rfly, and example filters for functions.php:

    http://pastebin.com/Vn9BWrZj (link expires after 7 days)

    Plugin Author neilgee

    (@neilgee)

    10 years, 8 months ago

    Filter also now added in version 1.6.2 – instructions – https://wpbeaches.com/slicknav-wordpress-filter-to-adjust-values/

    Thread Starter Ov3rfly

    (@ov3rfly)

    10 years, 8 months ago

    Thanks for the update, the filter works fine.

    Some additional notes/issues:

    4. Not yet complete, check_admin_referer() is missing, CSRF still possible.

    9. Output in frontend causes php warnings if no options are saved yet and WP_DEBUG enabled.

    10. Global variables $plugin_url and $options are not required. General note: If a plugin uses global variables, a prefix is recommended.

    11. get_option() returns false if not found, not empty string.

    12. Check for “Search option is ticked” should be cast to boolean.

    Here a changed version of 1.6.2 which fixes all the above issues, changes are marked with // Ov3rfly

    http://pastebin.com/8D6YXfk9 (link expires after 7 days)

    Questions welcome, thanks for the great plugin.

    Plugin Author neilgee

    (@neilgee)

    10 years, 8 months ago

    Thanks again, I thought I had the nonce sorted, it is ok now, most of these now rolled into version 1.6.3

Viewing 8 replies - 1 through 8 (of 8 total)

The topic ‘Some issues & suggestions’ is closed to new replies.