Some problems in 4.8.1

  • Resolved burnuser

    (@burnuser)


    7 years, 5 months ago

    Thank you for ongoing development!

    But I have found some problems in 4.8.1 on WP 5.0.1:

    a) “Hybrid Block Editor Mode” can not be deactivated (Removing the check mark is possible, but after saving it is checked again.)

    b) Last icon (having added some more) on the right end overlapping with “More options” icon in “Classic Paragraph” block (but works in “Classic” block)

    c) “Convert to” icon (Change block type) is lost in normal view for “Classic Paragraph”, only available – and working – if “Top Toolbar” option is checked.

    d) Difference between “Classic” block and “Classic Paragraph” Block is not evident and also removed after saving and reloading the page => all “Classic Paragraph” blocks are converted to classic block.

    Suggestion to simplify all things:
    As far as I can see – in the moment – the whole effect is based on replacing “Paragraph” block with “Classic Paragraph” block als default.
    But as “Classic Paragraph” acts like “Classic” block (and is also converted to it) the same effect (maybe with less problems and always 100% standard conform) could be reached with replacing “Paragraph” block with “Classic” block. Without the between step of using a “Classic Paragraph” block.
    => Instead of “Hybrid” etc. make a simple checkmark: “Replace Paragraph block with Classic Block as default” (and let Paragraph block untouched and still selectable)

    e) Classic block can not be used in reusable blocks. If replacing paragraph block as a whole, the “Reusable blocks” feature has no possibility for text content.

    f) Also existing reusable blocks with Paragraph blocks in it are not shown correct in editor view (Paragraph part not shown), but OK in WEB view.

    g) Also the block options of regular Paragraph block are not view- and editable if existing and new paragraph blocks are converted to “Classic Paragraph” blocks.

    But a possibility for a manual conversion of a selected block to “Classic” would be the solution for a lot of formatting problems!

    • This topic was modified 7 years, 5 months ago by burnuser.
    • This topic was modified 7 years, 5 months ago by burnuser.
    • This topic was modified 7 years, 5 months ago by burnuser.
    • This topic was modified 7 years, 5 months ago by burnuser.
Viewing 13 replies - 1 through 13 (of 13 total)
  • Plugin Author Andrew Ozz

    (@azaozz)

    7 years, 5 months ago

    Difference between “Classic” block and “Classic Paragraph” Block is not evident and also removed after saving and reloading the page => all “Classic Paragraph” blocks are converted to classic block.

    This is actually a feature, not a bug. It keeps the Classic Paragraphs compatible even if that option is turned off or the plugin is deactivated. See the description 🙂

    Last icon (having added some more) on the right end overlapping with “More options” icon in “Classic Paragraph” block (but works in “Classic” block)

    This and the rest of the CSS problems seem caused by caching? Can you clear the browser cache and refresh the page a few times. Does it look like in the screenshots?

    “Hybrid Block Editor Mode” can not be deactivated (Removing the check mark is possible, but after saving it is checked again.)

    Hmm, that’s strange. Perhaps try uninstalling the plugin and install it again? It is a form submission and handled in PHP, not sure why it would fail 🙁

    • This reply was modified 7 years, 5 months ago by Andrew Ozz.
    Thread Starter burnuser

    (@burnuser)

    7 years, 5 months ago

    a) Did a lot of testing with enable/disable “Hybrid Block Editor Mode” on different sites:
    Deleting + reinstalling or New installing Plugin does not help.
    But I found out that it CAN be disabled if any other item in “Advanced Options” section is checked! (If unchecked afterwards, the Hybride Mode is active again!)

    b) last icon: No problem if “Enable the Editor menu” is checked. But collision if unchecked. But works in original Classic block.

    d) I have read the description, but I still think that the usage of an additional “Classic Paragraph” block which only lives temporary and is converted to a regular “Classic” block on page refresh is not necessary and useful.
    Use “Classic” block directly instead.

    e) + f) Automatic conversion of “Hybrid blocks” destroys “Reusable blocks” feature. (So “Hybrid” – as it is – is no option for me and many others.)

    g) But as you demonstrated, you can convert paragraph blocks to Classic block, and this feature as manual option for individual blocks would be really great!
    (At least for Paragraph blocks, but – if possible – also for all other standard blocks like List and Quote.)

    Plugin Author Andrew Ozz

    (@azaozz)

    7 years, 5 months ago

    Thanks for the review, really appreciate it 🙂

    But I found out that it CAN be disabled if any other item in “Advanced Options” section is checked

    last icon: No problem if “Enable the Editor menu” is checked. But collision if unchecked. But works in original Classic block.

    Uh, there are bugs. Fixing.

    I have read the description, but I still think that the usage of an additional “Classic Paragraph” block which only lives temporary and is converted to a regular “Classic” block on page refresh is not necessary and useful.
    Use “Classic” block directly instead.

    Yeah, the first thing I tried was to replace the Paragraph block with the Classic block. Unfortunately that’s not possible. Also, having a “new” block has some advantages, can add conversion support, more attributes, etc.

    Automatic conversion of “Hybrid blocks” destroys “Reusable blocks” feature.

    Yeah, I went with the “most useful for most users”, but should probably leave the Classic Paragraph Blocks in the source. That will make them more useful in several cases, even in cases where the (standard) Classic Block won’t work.

    you can convert paragraph blocks to Classic block

    Yep, think so too. Will look for a way to add that conversion when the Classic Paragraph block is not used.

    • This reply was modified 7 years, 5 months ago by Andrew Ozz.
    Thread Starter burnuser

    (@burnuser)

    7 years, 5 months ago

    OK, some more feedback 🙂

    Replacing the paragraph block with classic is not necessary. Making Classic as default (instead of paragraph) would be very helpful.
    But make Paragraph block (and other blocks) individual convertible to Classic will re-enable the freedom in design of TinyMCE!

    And that’s a solution for all users:
    1.) Paragraph block remains untouched and works also in reusable blocks
    2.) No automatic conversion but possibility to convert Paragraph (and other blocks) to Classic. So if I need inline-formatting in a regular block, I simple convert it to Classic.

    about having a new block:
    Would be OK when:
    i) additional (regular Paragraph block – and reusable blocks – still alive)
    ii) living longer than to first page refresh
    … converting it to Classic can be done:
    A) manual and individual
    B) when plugin is deinstalled

    Last not least:
    Enabling additional inline-formatting for the regular block toolbar (Paragraph, List, Quote, …) would be the most standard compatible and helpful way ever!

    Like (posted earlier):
    https://ww.wp.xz.cn/plugins/advanced-rich-text-tools/
    https://github.com/iseulde/advanced-rich-text-tools
    With a combination of toolbar and block-sidebar and an additional very useful “Remove All Formatting” for the whole block option.

    Plugin Author Andrew Ozz

    (@azaozz)

    7 years, 5 months ago

    Nice wishlist, very close to what I wanted to do 🙂

    Making Classic as default (instead of paragraph) would be very helpful.

    That’s only partially supported in Gutenberg for now. May be fixed in the future.

    make Paragraph block (and other blocks) individual convertible to Classic will re-enable the freedom in design of TinyMCE!

    Looked at that, seems not possible for now, maybe in the future.

    converting it to Classic can be done:
    A) manual and individual
    B) when plugin is deinstalled

    The B won’t be possible as posts are saved in the DB. Trying to look in the DB, find the posts that may need conversion, then do the conversion automatically (without using the editor) would be… pretty buggy with many edge cases.

    So that will leave the users with “broken” blocks when they uninstall the plugin and try to edit an old post. Currently Gutenberg can convert these blocks to “Raw HTML” which may be OK in some cases, hoping we can add there to convert to Classic.

    Enabling additional inline-formatting for the regular block toolbar (Paragraph, List, Quote, …)

    Not possible. Specifically disabled as in most blocks the HTML attributes are also block attributes. If some are added or removed by a plugin, the block becomes invalid when the plugin is uninstalled.

    This may change in the future, will keep an eye on it 🙂

    Thread Starter burnuser

    (@burnuser)

    7 years, 5 months ago

    Enable additional inline-formatting for regular block toolbar

    Not possible. Specifically disabled as in most blocks the HTML attributes are also block attributes. If some are added or removed by a plugin, the block becomes invalid when the plugin is uninstalled.

    You are right, that was the fact – until 3 weeks or so. But since then most of them work!

    I made some – working – tests:

    Formatting:
    *) Font Family
    *) Font Size
    *) Text Color
    *) Background Color
    *) Subscript
    *) Superscript
    *) Special character
    *) Nonbreaking Space

    All convertible Standard-Blocks:
    x) Paragraph
    x) List
    x) Quote
    x) Heading
    x) Verse
    x) Preformatted

    Test:
    1. Used this formats in Classic block
    2. Duplicate block
    3. Converted Duplicate to blocks
    4. Converted blocks to each other (all possible conversions)
    5. Formatting works!
    6. Deinstalled TinyMCE Advanced
    7. All formats are unchanged, blocks are valid
    8. Reinstalled TinyMCE Advanced
    9. All special formats are editable (in Classic) again

    The only not correct working (but with open tickets):
    a) Nonbreaking space works, but is not encoded
    https://github.com/WordPress/gutenberg/issues/3549
    b) Justify
    https://github.com/WordPress/gutenberg/issues/8450

    But the above listed are approved as working – You can go on with re-establishing inline formatting in Gutenberg 🙂

    Plugin Author Andrew Ozz

    (@azaozz)

    7 years, 5 months ago

    Yeah, Gutenberg keeps evolving at a very fast pace. Many things are getting fixed even at this moment (I have few open PRs for there too) 🙂

    The main problem is that the TinyMCE instance in all blocks except Classic is hidden. It is not possible to change the configuration freely, only a little bit for predefined settings. If there is a way set the buttons and plugins loaded, it’d be great way to extend these blocks, unfortunately it doesn’t look that way.

    I understand that extending the toolbars for all blocks that support “rich-text” will probably never happen as it would bring a lot of other issues. Just trying to find a way to make the best of both editors available 🙂

    Plugin Author Andrew Ozz

    (@azaozz)

    7 years, 5 months ago

    Have a look at 4.8.2 (just released). Big part of the above wish list is in there. No buttons to blocks with rich-text added for now, that’s coming up next 🙂

    Thread Starter burnuser

    (@burnuser)

    7 years, 5 months ago

    Yes man, much better!
    Now it works with reusable blocks too!

    Some tests about conversion:
    a) Conversion of default blocks to Classic Paragraph works great!
    b) Conversion from Classic Paragraph to default blocks is limited to “Classic” and “Paragraph”
    c) But complete workflow cycle with 3 steps is working:
    1. Convert default block to “Classic Paragraph” (+ do/edit some inline-formatting)
    2. Convert “Classic Paragraph” to “Classic”
    3. Convert “Classic” to Blocks

    The “Convert to Blocks” option of “regular “Classic” would be great in “Classic Paragraph” to save one step!

    But anyway, a big Thank You for making inline-formatting available again 🙂

    Plugin Author Andrew Ozz

    (@azaozz)

    7 years, 5 months ago

    The “Convert to Blocks” option of “regular “Classic” would be great in “Classic Paragraph” to save one step!

    Right. Tried to add that but seems impossible from a plugin (for now). There is no reference to the block when you add an item to that menu from a plugin… That will probably be fixed soon, then will look again.

    When you convert from Classic Paragraph to a Paragraph it actually works in pretty much the same way like “Convert to blocks”. It’s a bit buggy when there are no paragraphs in the content, but otherwise works well. Was trying to get at least the “Convert to blocks” icon to show in the “covert menu”, but unfortunately that’s not possible without a very ugly hacks.

    Thread Starter burnuser

    (@burnuser)

    7 years, 5 months ago

    You are right, convert “Classic Paragraph” to “Paragraph” works for most blocktypes. In my tests only “Quote” block refuses this conversion (no interface-reaction at all). In this case only the 2 step way “Classic Paragraph” => Classic => Convert to Blocks works.

    Knowing this fact, a usable workflow exists for all cases. Maybe you should dokument these workflow options in your Plugin description / FAQ ?

    And don’t be too modest with version numbers. At least in the next version, with the announced buttons for regular Gutenberg blocks, a version number 5.0 (also symbolic for full Gutenberg integration) for your Plugin would be fully appropriate 🙂

    Plugin Author Andrew Ozz

    (@azaozz)

    7 years, 5 months ago

    a version number 5.0 (also symbolic for full Gutenberg integration) for your Plugin would be fully appropriate 🙂

    Hehe, yep, you’re right 🙂

    Plugin Author Andrew Ozz

    (@azaozz)

    7 years, 4 months ago

    Most (all?) of this should work well in v.5.0. Thanks @burnuser for testing and for the suggestions 🙂

Viewing 13 replies - 1 through 13 (of 13 total)

The topic ‘Some problems in 4.8.1’ is closed to new replies.