Plugin Contributor
Savvas
(@savvasha)
Hi @pilam ,
I am sorry to hear that… Unfortunately SportsPress is not yet 100% compatible with Gutenberg editor.
As you said, the error started to appear after upgrading YASR plugin. If I was you, I was going to start from there. Open a ticket at YASR site and give back some feedback here as soon as you have something new!
Thanks,
Savvas
Thread Starter
pilam
(@pilam)
Hi @savvasha,
I’ve done that:
https://ww.wp.xz.cn/support/topic/2-3-3-upgrade-problem-with-gutenberg/
and YASR’s author appears to be able to recreate it with YASR disabled, although that is the only trigger I’ve discovered so far. However I can confirm what he says about the error appearing even when the shortcode is not in the post – the same happened to me.
Something is trying to initialize the plugin when Gutenberg is enabled, even when it is not in the post.
HTH,
Pilam.
Plugin Contributor
Savvas
(@savvasha)
Hi @pilam,
Can you give me the exact steps to reproduce the issue? I am starting with a fresh WordPress install. Then install and activate SportsPress. Then what?
Thanks,
Savvas
Thread Starter
pilam
(@pilam)
Hi @savvasha,
Sorry for the delay in getting back. I have a lot more plugins I use and I was trying to eliminate as much as possible by doing a fresh install myself. That didn’t give me any clues but then I noticed that the problem only occured when opening an existing popup to modify it. If I added a completely new one it worked fine.
I then realised that those popups which had the problem all had classic blocks in them, i.e. the Classic Block formatting in Gutenberg. Remaking those blocks as ordinary Gutenberg paragraphs or similar eliminated the problem completely. (Adding a classic block brings it back though!).
So I still don’t know what actually caused the problem, but as long as Classic Block formats within Gutenberg aren’t used, the error doesn’t appear.
Again, sorry it took so long, but this can be closed from my perspective.
Thanks,
Pilam.
Hi Pilam,
That’s amazing, thanks for sharing your feedback!
And I’m glad it is solved for now. If you need anything else just let us know.
Thanks!
Plugin Contributor
Savvas
(@savvasha)
Hi @pilam ,
Thanks for the feedback. I hope that everything is working fine with your setup.
Thanks,
Savvas
Hi! I have the same problem on my site. But there is very simple solution!
Please, update row sportspress/assets/js/admin/editor.js ( 14 )
var shortcodes = variations.split("|");
=>
var shortcodes = typeof variations!== 'undefined' ? variations.split("|") : [];
It will only improve your code, thank you for your plugin!
Hi liubovwp!
Thanks for your suggestion! Please kindly send it on gitbub, that’s the best place for it to be considered for inclusion.
Thanks!
Kind Regards,
-Roch
Done: Fix Elementor compatibility #385
Any assistance will be appreciated.
That’s amazing, thanks for that π
Plugin Contributor
Savvas
(@savvasha)
Thanks @liubovwp for the contribution!!!
As I can see, the patch was already merged to the core code by our developers.
Thanks again,
Savvas