• Resolved atomizer

    (@atomizer)


    LL (0.4.0) stopped working for iframe content for some reason – the only change i made to this content was to wrap it in a div – here’s some sample code:

    <div class="embed-container"><iframe src="https://www.youtube.com/embed/YcxGGnmRQAs?feature=oembed" allowfullscreen="" height="453" width="604"></iframe></div>

    sample page:
    12bytes.org/articles/exposed/electronic-voting-machine-fraud

    i’m not seeing any php, wp_debug, or browser console errors

    https://ww.wp.xz.cn/plugins/lazy-load-xt/

Viewing 13 replies - 1 through 13 (of 13 total)
  • Plugin Author dbhynds

    (@dbhynds)

    If you remove the .embed-container div, does it still work?

    How are you adding the embed-container? Are you manually coding it straight into the content field of the post/page? Or are you using some sort of shortcode/plugin to generate the div with the video inside it?

    Thread Starter atomizer

    (@atomizer)

    div was added in functions.php…

    /* add div container for embedded objects for styling */
    if ( ! function_exists('my_embed_oembed_html') ) {
    	add_filter('embed_oembed_html', 'my_embed_oembed_html', 99, 4);
    	function my_embed_oembed_html($html, $url, $attr, $post_id) {
    		return '<div class="embed-container">' . $html . '</div>';
    	}
    }

    when i add a video in a post/page, i use the new embed method, which is just to paste the URL on a new line – that’s it

    give me a bit and i’ll remove it and post back – i started this post before i realized how i added it…

    Thread Starter atomizer

    (@atomizer)

    no, removing the div did not solve the problem

    glad you prompted me to look at my functions.php though – made a hell of a mistake there in that i had all my custom code duplicated πŸ™‚

    Plugin Author dbhynds

    (@dbhynds)

    It looks like it’s a problem with my regex function. I’ll do some more digging and see if I can figure out what this issue is. I’ll let you know.

    Thread Starter atomizer

    (@atomizer)

    i’m no expert in RegEx, but i do know my way around it a bit if you need help

    for testing, this is a great site:
    https://www.regex101.com/

    Plugin Author dbhynds

    (@dbhynds)

    Ok, I found a mistake in my regex. I’ll get an update out soon. Thanks for your patience

    Thread Starter atomizer

    (@atomizer)

    no problem – take your time – no hurry here

    thanks for looking into the issue

    Plugin Author dbhynds

    (@dbhynds)

    I’ve got a development version here: https://downloads.wp.xz.cn/plugin/lazy-load-xt.zip

    Try it out and lemme know how it goes.

    Thread Starter atomizer

    (@atomizer)

    works like a champ after a quick test

    i’ll keep an eye out and let you know if i find anything down the road

    i’ll let you mark this as resolved

    thanks!

    here, have a cookie…

    Thread Starter atomizer

    (@atomizer)

    oh, if you accept PayPal donations, give me a link

    Thread Starter atomizer

    (@atomizer)

    oops – one more question…

    will WP detect updates to this test build, or should i re-activate the release build?

    Plugin Author dbhynds

    (@dbhynds)

    Hey,

    I released a patch today that fixes this issue, plus a few others. You should see an update available for it in the admin. I don’t think you’ll need to reinstall it (although, to be honest, I’ve never tested that theory).

    Let me know how it goes. Also, I’ve got a donation page set up, but that’s certainly not necessary.

    Thread Starter atomizer

    (@atomizer)

    i’m actually using another LL plug at the moment, but i’m glad you got this issue resolved πŸ™‚

    i appreciate the update

Viewing 13 replies - 1 through 13 (of 13 total)

The topic ‘stopped working for iframe content’ is closed to new replies.