• Resolved Sanjay Gandhi

    (@sanjay-gandhi)


    Very nice plugin! My only suggestion for a future update is to not include the generic word ‘popup’ in the ‘class’, to avoid possible conflict with other plugins and theme files.

    You use class=”popup”
    I would say use something like class=”alli-popup” or class=”gator-popup”

    That would make it really unique.

    Thanks
    Sanjay

    https://ww.wp.xz.cn/plugins/alligator-popup/

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author cubecolour

    (@numeeja)

    Thank you for the suggestion Sanjay. When the plugin was first built. I carefully considered what to use for the class and the shortcode and used ‘popup’ to make it as simple and memorable as possible when adding the class directly to a link in the html as well as when using the shortcode. It was expected that if these were already used on a site, this plugin would not offer anything that was not already available and the site owner would already be able to create popup windows.

    The only themes I am aware of that may be affected by a shortcode or class conflict have been themeforest themes which are marketed with the ridiculous number of features as the main selling point – even if most people never use those features or it results in a large number of unneccesary scripts being loaded on every page load. As far as I know, no themes listed on the ww.wp.xz.cn theme directory would be affected as themes should not include features that should be plugin territory.

    If I change this, it may cause problems for existing users who update but I will put it on my to to-do list to investigate the possibility to accomodate this without breaking compatibility for anyone already using the plugin.

    Thread Starter Sanjay Gandhi

    (@sanjay-gandhi)

    Hi,
    Great…another plugin author had the same issue (he was using ‘hide’ then incorporated ‘hidethis’ without breaking compatibility)…
    https://ww.wp.xz.cn/plugins/hide-this/changelog/

    just in case it helps you.

    Your plugin is really nice, once again!

    Sanjay

Viewing 2 replies - 1 through 2 (of 2 total)

The topic ‘suggestion’ is closed to new replies.