• Resolved digiblogger

    (@digiblogger)


    Hi Antoine,

    As I see, your plugins output switched to a box mode (mobile friendly or not).
    I loved the table version before. Why you removed it?
    I would really love to have it back.

    Best regards
    Digi

Viewing 15 replies - 1 through 15 (of 16 total)
  • Plugin Author AntoineH

    (@antoineh)

    Hi Digi,

    The old table layout is still available from the settings page.

    Thread Starter digiblogger

    (@digiblogger)

    Really?
    I only find “classic layout” and “mobile friendly layout” and both are box layouts

    Plugin Author AntoineH

    (@antoineh)

    Classic layout is the table layout.

    Can you tell me which plugin version you are using? And if you have any extensions activated?

    Thread Starter digiblogger

    (@digiblogger)

    They both look nearly the same. One is dark, the other mobile friendly is lighter.

    it’s version 2.97

    Extensions for Football Pool? No. Are there any?

    Thread Starter digiblogger

    (@digiblogger)

    Oh by the way. the german translation is somewhat terrible. you get a better one after i am done

    Thread Starter digiblogger

    (@digiblogger)

    could you allow HTML in the stadium description?

    Plugin Author AntoineH

    (@antoineh)

    They both look nearly the same. One is dark, the other mobile friendly is lighter.

    it’s version 2.97

    They should be very different in how the HTML source is built up. The new layout uses flex containers, which makes it easier to rearrange the individual blocks via CSS. A table layout is very rigid.

    classic layout
    See https://www.dropbox.com/s/mesem05vlki529r/prediction-table-classic-layout.png?dl=0

    new layout
    See https://www.dropbox.com/s/xw0ejo2bi3j2ojn/prediction-table-mobile-friendly-layout.png?dl=0

    Extensions for Football Pool? No. Are there any?

    Yes, they are scattered across the forum posts. But I also grouped some in the pinned message in this support forum.

    Oh by the way. the german translation is somewhat terrible. you get a better one after i am done

    That would be really great. But it is better if you upload your changes (here) to the official translation website of WordPress for my plugin and ask if you can become a PTE (=project translation editor, this will give you rights to approve your own translations). That is the officially supported route for translations and also the only way because I am not allowed to accept your translations on this site since I am not a native German speaker. I can also request the PTE status for you after you’ve uploaded your translations.

    Plugin Author AntoineH

    (@antoineh)

    could you allow HTML in the stadium description?

    By default? No. Because that would introduce a security risk (cross site scripting, or XSS).

    But I do have a work-around that you can use at your own risk*. Add the following to your wp-config file:
    define( 'FOOTBALLPOOL_ALLOW_HTML', true );

    *) There are also other ways to introduce HTML via the WordPress admin, e.g. via blocks, so the risk is minimal. The reason I do not have it enabled by default is because my plugin could then be flagged as having a security vulnerability by (automated) vulnerability checkers.

    Thread Starter digiblogger

    (@digiblogger)

    Hi Antoine,

    yes, you are right. The HTML and CSS is different, but it looked the same on my site.
    I changed some CSS and now I can see the difference.

    I also changed some rows in the shortcode output for the group tables, so now every column has a heading and is translateable. I will send you the plugins files after I made all changes and you can have a look on it (if this is interesting for you).

    Extensions: I tried to find them and searched trough a lot of forum pages here. No success. It would be great to have them in the plugin decsription or as downloadable extensions like Plugin Addons are packed and shown in the WordPress Repository.

    Translations: Yes, I will upload my files there.

    Suggestions:
    As I played around with your plugin and searched through matching posts in the forum, I have a lot improvements in mind.

    1. Somebody asked for the possibility of having multiple different competitions at one. You answered that this would result in a page slow down and in the fact that the plugin will calculate scores for these multiple leagues, everytime something is changed. Well, yes, this would need some code rewriting, but it should be possible to mark a match type as archived (like it can be marked as visible on the page) and just exclude archived match types from recalculation. Sounds not so hard to do for me.
    2. Matchdays: Your plugin uses the date to group matches. This can be used, but every league and every tournament has matchdays (even the WC in Qatar has three match days in the group phase). This could make it easier to display only the desired match and prediction data.
    3. Team Page: On The team page, i get just an ordered and numerized list of teams. I did not fill in all data, but obviously, the teams are only shown with photo (not flag), description and link. Well, it would look a lot better when transforming this list into a table view and also add the flag to the view like: Flag|Photo|Teamname|Description|Link,Group,Current Standing
    4. The date in the match/prediction and other pages should be use the wordpress format or just allow to format it in settings
    5. The teams and group tables should be displayed in columns. I know, this can be done manually for groups, but when you allow the assignment of pages to plugin functions, why don´t allow to configure them a little deeper?
    6. For all description fields, it would be nice to allow html inside the fields, cause it is not possible to have any formatting inside those descriptions.
    7. Players: There is no player feature but this would improve the plugin a lot. If the admin can assign scorers and maybe assists (both with minute) to the result of a match, this could be used create questions like first goal in match or tournament or best scorer, best assist or most goals in tournamend or group phase or something. and of cource, this could be expanded to yellow and red cards and other match events for questions like most unfair team. And they could be shown under the results.

    just some ideas 🙂
    Have a nice day

    Thread Starter digiblogger

    (@digiblogger)

    Hi Antoine,

    first of all: I uploaded my translation and the status is waiting. Don´t know whats happens now, but its uploaded.

    Here are some missing translations I found:

    1. “back to top” on Options Page
    2. “Select some Options” in Options Page (Group Page Options)
    3. “Dashboard” Link in Options Page (Other Options)
    4. “The plugin uses normal WordPress pages to display the content in the plugin (e.g. the ranking). In this section you can define which pages the plugin should append the content to. The plugin creates pages on first install for every page needed in the plugin.” in Plugin Options (Plugin Pages)
    5. “(e.g. 2022-06-02 18:00)” in question page answer until and score date.
    6. The Full help page

    The Date shown on the precition and match page can not be customized and is always US format. Maybe you can customize this.

    Also, I made some cusomizations for the group table shortocde (to show headings). If you want me to send the file, just mail to [email protected].

    Have a nice day
    Digi

    Plugin Author AntoineH

    (@antoineh)

    Thanks for the suggestions/improvements. I will have a look at them.

    first of all: I uploaded my translation and the status is waiting. Don´t know whats happens now, but its uploaded.

    I’ve requested for you to become a PTE. Someone from the German polyglot team will have to approve this (they may come back to you with some comments or questions). But once you have become a PTE you can select all “waiting” translations and approve them. They will then come available for everybody as a language pack (this takes some time).

    I will have a look at the missing translations. Thanks for that.
    I won’t translate the full help page, though 😀 That is too much work.

    It would be great to have them in the plugin decsription or as downloadable extensions like Plugin Addons are packed and shown in the WordPress Repository.

    If I add the extensions to the WP repo I also have to support them. And I do not officially support the extensions. They are ‘examples’ of how you can extend the plugin and may work as a basis for others to work on.

    The Date shown on the precition and match page can not be customized and is always US format. Maybe you can customize this.

    Version 2.10.0 and above will have this.

    Plugin Author AntoineH

    (@antoineh)

    I fixed the translations in my dev version, except for:

    • “back to top” on Options Page ==> removed in new version
    • “Select some Options” in Options Page (Group Page Options) ==> is part of a javascript library that I cannot translate
    • The Full help page ==> won’t do
    Thread Starter digiblogger

    (@digiblogger)

    Well you can add the whole sections as a translation phrase so you just need to add the text domain to the text blocks on the help page. It’s not so much work. Ich will check the template Tomorrow. I am not a good coder but I can do a little.

    After this, I will also send you the file with my changes for the group standings template.
    And if you like, also my css changes.

    I would prefer styling templates and shortcode output in backend options cause it’s easier to customize for branded websites. Table headers, rows even and odd, hover, borders and similar. Without Stylings, the classic layout looks really crazy on my site. Especially the flags and input boxes plus the joker icon are not aligned in any way.

    Thread Starter digiblogger

    (@digiblogger)

    I added, rechecked and approved the german translation in my new PTE function.
    German translation is now 100% complete.

    This was a pretty hard work 🙂

    Plugin Author AntoineH

    (@antoineh)

    I appreciate the hard work! Finally the German translations also get a translation pack.

    And congrats on the new badge in your profile 😀
    https://profiles.ww.wp.xz.cn/digiblogger/

Viewing 15 replies - 1 through 15 (of 16 total)

The topic ‘Table Mode Please’ is closed to new replies.