Title plugin conflict

  • nppbc

    (@nppbc)


    11 years, 10 months ago

    All-in-one Event is conflicting with this awesome plugin. What they have said is this,
    “@nppbc – Your sharing plugin is using the_title() function (which includes HTML in the title if it exists), when it should be using the_title_attribute() function (which does NOT include HTML – it strips HTML from the title) to fetch the title of the post from WP.
    As such, your sharing plugin has a bug that the plugin author should fix.”

    Can this be corrected?

    https://ww.wp.xz.cn/plugins/simple-share-buttons-adder/

Viewing 1 replies (of 1 total)
  • cefiar

    (@cefiar)

    11 years, 10 months ago

    FWIW: Looking briefly through the code it’s using get_the_title() in two places, both of which probably should be replaced with the_title_attribute() assuming that the plugin runs in the loop.

    If it doesn’t run in the loop, then you should really consider stripping HTML tags from get_the_title() using something like strip_tags() or the like.

    They’re in the file simple-share-buttons-adder.php and appear on lines 701 and 707.

    Hope this helps.

    BTW: Where this breaks most often is when the title gets used as a html tag attribute and it itself contains an attribute. As soon as the second quote is hit, the html becomes invalid.

Viewing 1 replies (of 1 total)

The topic ‘Title plugin conflict’ is closed to new replies.