Token expiry for deleted users

  • Resolved Nifty

    (@niftythree)


    3 years, 5 months ago

    Hi Murali,

    When a user deletes themselves in BuddyPress/user is deleted in WordPress, does the plugin revoke the token for the user? We are seeing that the token still remains (24+ hours since we last checked). Would it be possible for the token to deleted when the user no longer exists? This would allow deleted users to be immediately excluded from notifications, such as an on demand push notification.

    Thank you. 🙂

Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Author Murali

    (@murali-indiacitys)

    3 years, 5 months ago

    Since push notification is based on device subscription (with or without logged in), token will be exist until corresponding device un-subscribed/blocked by the user from their device browser. Once it is unsubscribed then it will automatically get deleted during next notification.

    For your request, i can add new option in plugin settings area to delete token with userid when corresponding user deleted/no longer exist. So that website admins can enable or disable according to their choice. I will add this change in upcoming release. Push notification subscription in this plugin is mainly based on device subscription not based on logged in users (For WordPress websites). If your android app is designed to get subscription after logging in then you can enable this option so that token will always has user id. For other general WordPress website users, token may or may not contain user id as it can be subscribed with or without logging into website.

    I will add new option to enable/disable delete token when user id not exists, so that website admins can enable/disable according to their choices and if they enable then it will delete only tokens with userids which does not exist and tokens without user id will still exist until user un-subscribes it from their browser.

    Thread Starter Nifty

    (@niftythree)

    3 years, 5 months ago

    Thanks Murali, that sounds great. We really appreciate you adding this option. We’ll look forward to the update. 🙂

    Thread Starter Nifty

    (@niftythree)

    3 years, 5 months ago

    Hi @murali-indiacitys

    Thanks for sending out the plugin update.

    We’ve done some testing, and have noticed that for deleted users tokens to actually be removed, the “Schedule automatic delete tokens without userid (userid=0)” option has to be off. That is, if both “Schedule automatic delete tokens with userid no longer exist” and “Schedule automatic delete tokens without userid (userid=0)” options are on, the tokens for deleted users do not get removed. Is this how it’s supposed to work?

    We also noticed that when the cron job schedule is changed, “Save changes” sometimes needs to be clicked twice, before it appears to be updated.

    We’re using the WP Crontrol plugin to check the schedule.

    Thanks.

    Plugin Author Murali

    (@murali-indiacitys)

    3 years, 5 months ago

    i will look into it soon. I will update you in 2 days. I was not feeling well last 2 days and i will look into this tomorrow or on Sunday i will update you

    Thread Starter Nifty

    (@niftythree)

    3 years, 5 months ago

    Hi Murali,

    Hope you’re feeling better soon! We’ll look forward to hearing back from you when you’re ready.

    Thanks.

    Plugin Author Murali

    (@murali-indiacitys)

    3 years, 5 months ago

    It is due to AND condition which should be OR condition while deleting tokens for both options . Due to this problem, it did not delete. I have updated the mysql query in 1.48 version. Please download 1.48 version. If you already scheduled the cron then change the cron schedule to some other schedule and check or use run now option in cron events to check or wait until the next run. Some time cron events will updated after a second. I found only problem related to AND condition due to which it did not delete with user id not equal to zero for deleted users. It is fixed in 1.48 version

    • This reply was modified 3 years, 5 months ago by Murali.
    • This reply was modified 3 years, 5 months ago by Murali.
    Thread Starter Nifty

    (@niftythree)

    3 years, 5 months ago

    Hi Murali,

    Thank you; this issue appears to have been fixed in the updated version. Thanks again for your ongoing dedication to this plugin.

Viewing 7 replies - 1 through 7 (of 7 total)

The topic ‘Token expiry for deleted users’ is closed to new replies.