Plugin Author
nK
(@nko)
Hi.
Have you tried our Tabs block without these masonry blocks inside?
Seems like output HTML is broken, but I’m not sure why is this happens:
Also look at w3 validator errors – https://validator.w3.org/nu/?doc=https%3A%2F%2Fsandbox.peoplesfactory.com%2Fde%2Fa-tab%2F
Regards, nK.
Hi,
Yes I have the same issue with a simple page, 3 tabs, plain text.
See here: https://sandbox.peoplesfactory.com/de/ein-tab-2/
Best regards,
Andreas
PS: Are you considering full support for WPML (wpml_config.xml files to configure what part pf the code needs translations)?
Additional info: I tried to deactivate all plugins, switched to the TwentyNineteen theme) – still the same issue.
I’ll keep the site in that state for a day or so – so you can check it out…
Plugin Author
nK
(@nko)
Hi.
I don’t have this problem on my install.
Please, give me a step-by-step guide, so I can repeat the bug. My steps are:
1. Create a page and add Tabs block from the inserter
2. Add some new tabs and content
3. Duplicate this page to use in different language, and on the new page will be these WPML settings:
4. Open page on site and switch to a different language
5. Tabs works on both pages
Regards, nK.
Strange, here are my steps:
I create the page in English, 3 tabs, some simple paragraph.
In the block editor, on Document level, I click on the little “+” sign next to “German” language, that brings me into the WPML translation editor (that shows English and German elements next to each other, it’s not the block editor).
Then I maintain the translation and save.
I have the core WPML plugin installed, plus the translation manager plugin…
so, the process is slightly different and I do not copy the page, but use WPML tools.
I can provide you access to our sandbox site, if a like…
Plugin Author
nK
(@nko)
I have checked it and seems like this “Translation Manager” plugin breaks the HTML parts of Accordion. As a solution, you can fix HTML manually when translating:
I don’t have much experience with WPML and not sure what exactly add in wpml_config.xml. I see in documentation support for Gutenberg blocks, but it is not working for me at all.
If someone has a solution, I’d be happy to look at it. Added GitHub issue: https://github.com/nk-o/ghostkit/issues/43
Regards, nK.
Thanks for the update, I have also opened a message with the WPML guys – they are still investigating, does not seem to be an easy to identify issue.
As for the wpml_config file, see below for an example that works for me (for the tabs) – hope that helps – would be great, if a complete file could become part of a future version of the plugin…
Best regards,
Andreas
<wpml-config>
<gutenberg-blocks>
<gutenberg-block type=”ghostkit/tabs-tab-v2″ translate=”0″></gutenberg-block>
<gutenberg-block type=”ghostkit/tabs-v2″ translate=”1″>
<xpath>//div/a</xpath>
</gutenberg-block>
</gutenberg-blocks>
</wpml-config>
Plugin Author
nK
(@nko)
Is this config fixes the bug for you?
I still see this bug also with your config added. Also, I have tried specific xpath with class name selected instead of just //div/a. Tried this config for Tabs and Accordions:
<wpml-config>
<gutenberg-blocks>
<gutenberg-block type="ghostkit/tabs-tab-v2" translate="0"></gutenberg-block>
<gutenberg-block type="ghostkit/tabs-v2" translate="1">
<xpath>//div[contains(concat(" ", normalize-space(@class), " "), " ghostkit-tabs-buttons ")]/a</xpath>
</gutenberg-block>
<gutenberg-block type="ghostkit/accordion" translate="0"></gutenberg-block>
<gutenberg-block type="ghostkit/accordion-item" translate="1">
<xpath>//div[contains(concat(" ", normalize-space(@class), " "), " ghostkit-accordion-item-label ")]</xpath>
<xpath>//div[contains(concat(" ", normalize-space(@class), " "), " ghostkit-accordion-item-content ")]</xpath>
</gutenberg-block>
</gutenberg-blocks>
</wpml-config>
Regards, nK.
Hi,
no this did not fix the issue, but it makes translation a lot easier as you don’t get to see all the HTML codes in the translation editor..
Best regards,
Andreas
