Two close buttons

  • Resolved nirgalo

    (@nirgalo)


    11 years, 5 months ago

    Hi, I have two close buttons on calendar event details (main calendar) when opening them. One top-right and one bottom-right. Looking at the code, it seems this is due to the fact my_calendar_draw_event() is called twice for a same event, once with $details true and another time with $details false. Is this expected and how to workaround that issue? I do not want two close buttons on my events! Thanks.

    https://ww.wp.xz.cn/plugins/my-calendar/

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author Joe Dolson

    (@joedolson)

    11 years, 5 months ago

    There should be two close buttons on each event; this is normal. With all the default stylesheets, they should be positioned right on top of each other, or the second should be hidden using off-screen positioning.

    In the source code, one should appear at the beginning of the details section, the other at the very end.

    The reason for having two close buttons is to provide better accessibility for screen readers and keyboard-only navigators, so they can close the details panels both at the beginning and the end of the details screen.

    Thread Starter nirgalo

    (@nirgalo)

    11 years, 5 months ago

    two close buttons is far from being standard in UX guidelines 🙂
    Would be nice if this was configurable in the plugin settings.
    In the meantime we can workaround this using the following CSS:

    #jd-calendar a.mc-close:last-child {
	display:none;
}

    Plugin Author Joe Dolson

    (@joedolson)

    11 years, 5 months ago

    Yes, in all honesty this is a work-around, not an ideal solution.

Viewing 3 replies - 1 through 3 (of 3 total)

The topic ‘Two close buttons’ is closed to new replies.