Type Comparison fix | ww.wp.xz.cn

Resolved baxterkh
(@baxterkh)

1 year, 6 months ago
Hello

I’ve a compatibility issues with third party plugins and I found the issue in your plugin. There is a problem with type comparison === in term_permalink() method – https://plugins.trac.ww.wp.xz.cn/browser/custom-permalinks/trunk/includes/class-custom-permalinks-frontend.php#L1102. I fixed this issue on my site, please include below fix in your next update.

Current code:
```
if ( $info['id'] === $term_id ) {
```
Fixed version:
```
if ( $info['id'] === (int) $term_id ) {
```

Viewing 2 replies - 1 through 2 (of 2 total)

Plugin Author Sami Ahmed Siddiqui
(@sasiddiqui)

1 year, 1 month ago

@baxterkh It is not a comparison problem. The term_permalink() function in plugin expects an integer for its $term_id parameter. Interestingly, I am not seeing any warnings or errors being triggered by WordPress regarding this incorrect parameter type.
Thread Starter baxterkh
(@baxterkh)

1 year, 1 month ago
@sasiddiqui if this method expects an integer value, please require it by declaring parameter type like:
```
public function term_permalink( int $term_id ) {
```
I cannot remember which kind of problem was here after 4 months. Please either add parameter type or convert it to int.

Viewing 2 replies - 1 through 2 (of 2 total)

The topic ‘Type Comparison fix’ is closed to new replies.

2 replies
2 participants
Last reply from: baxterkh
Last activity: 1 year, 1 month ago
Status: resolved