• Resolved g_ain

    (@g_ain)


    In master-slider/admin/includes/classes/class-msp-shortcode-factory.php, MSP_Shortcode_Factory::get_ms_slide_info_shortcode() method, the $css_class is undefined if slide info is anything other than empty string. Please initialize the variable so that it doesn’t throw notices:

    if( !$the_content )
        return '';
    
    $css_class = ( " " == $the_content ) ? 'ms-info-empty' : '';
    return sprintf( '[%1$s css_class="%3$s"]%2$s[/%1$s]', 'ms_slide_info', $the_content, $css_class )."\n";

    https://ww.wp.xz.cn/plugins/master-slider/

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Author averta

    (@averta)

    Dear friend,

    Thanks for using Master Slider.

    As I check the code, the $css_class variable always has a value ( ‘ms-info-empty’ or empty string ). Could you send me exact notice that you received in your installation?

    Kind regards

    Thread Starter g_ain

    (@g_ain)

    The code I attached is my patched version.

    Plugin Author averta

    (@averta)

    Dear friend,

    We released new version and already addressed this issue too, please update to latest version.

    BTW, Thanks for reporting and your patience.

    Regards

    Thread Starter g_ain

    (@g_ain)

    Looks like master slider pro 2.20.4 has the same issue.

    Plugin Author averta

    (@averta)

    Hi,
    Thanks for your report.

    Version 2.22.1 pro released on 4 nov 15.

Viewing 5 replies - 1 through 5 (of 5 total)

The topic ‘Undefined variable $css_class’ is closed to new replies.