Unreliable URL Replacement

Hi @jamesjosephfinn
Thanks for the details!

One question, Are you using plugin like Jetpack or another plugin that integrates their CDN into WP?
Do you know this url wp1.now.christendom.cloud?

@jamesjosephfinn

Could you please check one of these images that are loading from wp1.now.christendom.cloud to see if they are already offlaoded or not? What is their offloading status?

Hi @jamesjosephfinn ,

Thank you for the details!
The current wp_content_img_tag filter  that we are using to rewrite the image URLs in the post contents, relies on WordPress being able to identify the attachment ID from the wp-image-{ID} class. This filter may not fire correctly when:

1. Page builders (like Bricks) have their own rendering engines
2. Content is processed in non-standard ways
3. Images lack the wp-image-{ID} class

Workaround to Test:

Please add this function to your theme’s functions.php and check if it resolves the issue:

/**
 * Fallback filter to rewrite all upload URLs to S3/R2 in post content.
 */
add_filter('the_content', 'advmo_rewrite_content_urls', 999);
add_filter('render_block', 'advmo_rewrite_content_urls', 999);

function advmo_rewrite_content_urls($content) {
    if (empty($content)) {
        return $content;
    }
    
    $settings = get_option('advmo_settings');
    $provider = $settings['cloud_provider'] ?? '';
    
    if (empty($provider)) {
        return $content;
    }
    
    $provider_key = advmo_get_cloud_provider_key();
    $domain = advmo_get_provider_credential($provider_key, 'domain');
    
    if (empty($domain)) {
        return $content;
    }
    
    $domain = advmo_normalize_url($domain);
    
    $upload_dir = wp_get_upload_dir();
    $upload_base_url = $upload_dir['baseurl'];
    
    // Remove protocol from upload base URL to match both http and https
    $upload_base_url_no_protocol = preg_replace('/^https?:\/\//i', '', $upload_base_url);
    
    // Pattern matches both http:// and https:// versions of upload URLs
    $pattern = '/https?:\/\/' . preg_quote($upload_base_url_no_protocol, '/') . '\/([^"\'>\s]+\.(jpe?g|png|gif|webp|avif))/i';
    
    return preg_replace_callback($pattern, function($matches) use ($domain, $upload_base_url) {
        $full_url = $matches[0];
        $relative_path = $matches[1];
        
        // Normalize URL to match what's stored in DB (use the WP upload base URL protocol)
        $normalized_url = $upload_base_url . '/' . $relative_path;
        
        $attachment_id = attachment_url_to_postid($normalized_url);
        
        if (!$attachment_id) {
            $attachment_id = attachment_url_to_postid($full_url);
        }
        
        if (!$attachment_id) {
            // Try without size suffix (e.g., -300x200)
            $base_path = preg_replace('/-\d+x\d+(\.[^.]+)$/', '$1', $relative_path);
            $base_url = $upload_base_url . '/' . $base_path;
            $attachment_id = attachment_url_to_postid($base_url);
        }
        
        if (!$attachment_id) {
            return $full_url;
        }
        
        if (!get_post_meta($attachment_id, 'advmo_offloaded', true)) {
            return $full_url;
        }
        
        $advmo_path = get_post_meta($attachment_id, 'advmo_path', true);
        $filename = basename($relative_path);
        
        return rtrim($domain, '/') . '/' . ltrim($advmo_path, '/') . $filename;
        
    }, $content);
}

I would appreciate if you could share the result with us. It will help us to address the issue in the plugin for the next releases.

I am glad to hear the issue has been resolved for you. I will mark this as resolved on our end as well. We are tracking this in our internal system and a permanent fix will be included in the next release, at which point you can remove the snippet from your functions.php file.

Regarding attachment_url_to_postid(), it is my understanding that it does not always work reliably with specific image sizes. I may be mistaken, but that has been my experience when working with it previously.