URL Encoding on sitemaps

  • Felipe Lavín

    (@felipelavinz)


    13 years, 1 month ago

    WordPress version: 3.5.1
    WordPress SEO version: 1.4.7

    I did this: got an xml parsing error from Google Webmaster Tools

    I expected the plugin to do this: output valid xml 🙂

    Instead it did this: applied quick fix

    —

    Hi

    I recently found out from Google Webmaster Tools that some of my sitemaps where not being indexed because of a xml parsing error.

    The problem was that some of my URLs had ampersands that weren’t encoded, so taking a look at the plugin I tried a quick fix. On class-sitemaps.php, find the sitemap_url method and just before defining the $output, add:

    $url['loc'] = htmlspecialchars( $url['loc'] );

    This complies with the Sitemap protocol as defined on http://www.sitemaps.org/protocol.html#escaping

    Hope you can add it to the plugin to solve this for others that might have the same issue.

    http://ww.wp.xz.cn/extend/plugins/wordpress-seo/

Viewing 7 replies - 1 through 7 (of 7 total)
  • johnzenausa

    (@johnzenausa)

    13 years, 1 month ago

    Can you tell me what line to put it on? There is a ton of $output in the file.

    Thread Starter Felipe Lavín

    (@felipelavinz)

    13 years, 1 month ago

    Around line 553:

    function sitemap_url( $url ) {
		if ( isset( $url['mod'] ) )
			$date = mysql2date( "Y-m-d\TH:i:s+00:00", $url['mod'] );
		else
			$date = date( 'c' );
		$url['loc'] = htmlspecialchars( $url['loc'] );
		$output = "\t<url>\n";
    johnzenausa

    (@johnzenausa)

    13 years, 1 month ago

    It worked for one of the pages but on the following sitemap page I still get the following error:

    XML Parsing Error: junk after document element
Location: http://www.digitalcamerasmegastore.com/post-sitemap6.xml
Line Number 2, Column 1:<b>Fatal error</b>:  Unknown: Cannot use output buffering in output buffering display handlers in <b>Unknown</b> on line <b>0</b><br />
^

    Thread Starter Felipe Lavín

    (@felipelavinz)

    13 years, 1 month ago

    That’s a separate issue, a fatal error about something related with output buffers… Anyway, I just took a look at your sitemap and it seems fine now

    johnzenausa

    (@johnzenausa)

    13 years, 1 month ago

    What I did was lower the pages from 1000 per page to 500 and everything started working with or without the above code. Interesting.

    johnzenausa

    (@johnzenausa)

    13 years, 1 month ago

    I mean I lowered the links from the default 1000 to 500.

    Thread Starter Felipe Lavín

    (@felipelavinz)

    13 years, 1 month ago

    Yup, that’s a separate issue, perhaps related to memory consumption

Viewing 7 replies - 1 through 7 (of 7 total)

The topic ‘URL Encoding on sitemaps’ is closed to new replies.

Tags