URLs get mangled

Resolved platima
(@platima)

2 years, 3 months ago

I found that this causes issues, eg redirectors links to URLs with parameters that have ‘.’ get replaced with ‘_’ which results in broken links, failed redirects, etc.

Eg “https://shop.plati.ma/collections/all?filter.p.vendor=Milk-V” becomes “https://shop.plati.ma/collections/all?filter_p_vendor=Milk-V&swcfpc=1” which is a completely different page.

I’ve lost sales due to this now, so immediately deleted the plugin.

Viewing 5 replies - 1 through 5 (of 5 total)

Plugin Contributor iSaumya
(@isaumya)

2 years, 3 months ago
The plugin is not doing this. So, it can entier be some WP plugin/WP Core or Cloudflare URI Normalization feature.

Moreover, as per standard query param name should not have . it should either be separated by - or _ – just saying.
- This reply was modified 2 years, 3 months ago by iSaumya.
Thread Starter platima
(@platima)

2 years, 3 months ago

You are wrong sorry, the plugin is definitely doing this. I disabled the plugin, the problem is fixed, I re-enable the plugin, the problem comes back.

It’s also nothing to do with Cloudflare, I am not sure why you think that.

You are also incorrect about the URL parameters; a “.” is perfectly valid. This is a Shopify site, not like they’d get it wrong. Furthermore, if you read IETF RFC 3986 that confirms the legal characters.

Your arrogant response helps no one and is not appreciated.
Thread Starter platima
(@platima)

2 years, 3 months ago
I just downloaded the zip file, extracted it, and grepped it for str_replace. I don’t know how you can deny it’s your plugin doing it, when it is literally in the damn code;

/assets/advanced-cache.php:215: $cache_key = str_replace( $replacements, '_', $current_uri );

This is in the condition

has_filter( 'swcfpc_fc_modify_current_url' )

So yeah, ‘modify current URL’, pretty bloody clear mate, and bricks heaps of URLs it seems.
- This reply was modified 2 years, 3 months ago by platima.
Plugin Contributor iSaumya
(@isaumya)

2 years, 2 months ago

Hi @platima,
That code you have mentioned is coming from the fallback cache. Can you try disabling the fallback cache feature of this plugin to see if this resolves your issue? Unfortunately, in order for fallback cache to work it requires that code. You can keep using the plugin without the fallback cache.

Thread Starter platima
(@platima)

2 years, 2 months ago

I deleted the plugin and the site is live so cannot test this for you sorry.

I’d recommend testing yourself.

Viewing 5 replies - 1 through 5 (of 5 total)

The topic ‘URLs get mangled’ is closed to new replies.