• Resolved azitlies

    (@azitlies)


    The new version, while fixing many issues, will take a simple page (this happens when you update from 1.1 to 1.2 only – not after the update, but when you do the update) that has this text:

    
    <!-- wp:html -->
    <a href="https://xxxxxxxxxx.com/wp-content/uploads/2018/10/Bylaws.pdf" target="_blank" rel="noopener">Click here for Bylaws</a>
    <!-- /wp:html -->
    
    And change it to this: 
    
    <!-- wp:core-embed/wordpress {"url":"https://xxxxxx.com/ccrs-with-13th-amendment-2018/","type":"wp-embed","providerNameSlug":"xxxxxxxxhoa"} -->
    <figure class="wp-block-embed-wordpress wp-block-embed is-type-wp-embed is-provider-xxxxxxxxx"><div class="wp-block-embed__wrapper">
    https://xxxxxxx.com/ccrs-with-13th-amendment-2018/
    </div></figure>
    <!-- /wp:core-embed/wordpress -->
    

    These 2 examples aren’t of the same page, so the url’s are different, but the exact same thing happens no matter the url.

    Why does this matter? Well the wp-block-embed results in a thumbnail view of the pdf (the link is to a pdf), but it also adds the ability to make a comment? (wtf? – it’s a static page!), and it also has a button to copy and embed the link to a different website! Totally undesirable.

    • This topic was modified 7 years, 5 months ago by Steven Stern (sterndata).
    • This topic was modified 7 years, 5 months ago by azitlies. Reason: only happens when you do the update to 1.2. Once updated I think you can change it back and it will stick
    • This topic was modified 7 years, 5 months ago by Jan Dembowski.
Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Andrew Ozz

    (@azaozz)

    Looks like some “auto embed embeddable URLs” rule has triggered? I’d guess that would happen when you use the Block Editor, regardless of the Classic Editor plugin.

    Thread Starter azitlies

    (@azitlies)

    But it happened simply by updating this plugin from ver 1.1 to 1.2?

    I didn’t change anything, I didn’t use the block editor, I just updated the plugin and Voila! It changed by itself…

    Plugin Author Andrew Ozz

    (@azaozz)

    But it happened simply by updating this plugin

    Has it happened since then? As far as I can tell, this is probably a coincidence. Please open a new support request (with steps to reproduce the error) if that happens again.

    Thread Starter azitlies

    (@azitlies)

    Okay, this is what i think happened;

    Updating from wp 4.x.x to 5 (it’s now 5.1), made some changes by itself. I’m guessing because the default (only? there was no classic plugin installed) was the block editor, it modified some classes in the html;

    A perfect example would be wp-table, I think became wp-block-table. I just finished changing all mine back to wp-table, now, the new twentysixteen theme looks as it should (word wrap, borders, etc), but it didn’t after the update because it was using (new) blocks.css and editor-blocks.css (in the new version of the theme).

    I originally thought the classic plugin was the issue but it might have just been going to wp 5.x caused it. It *might* be wise to tell people to install the classic editor plugin prior to going to wp 5? If that’s even possible, as that editor is in core in 4.x.x?

    It’s really not clear what changed it, and I’ve no way to test it now. So it’s updated and all working, alas.

    I’d suggest one last thing, don’t say people are “afraid” to use the block editor… Me, I’ve used vi, dreamweaver, c++ and Java editors, programmed in assembler… etc etc etc

    It’s not fear, it’s a matter of spending hours and hours and hours, to do what? Make your website look exactly as it does already?

    That’s not fear, that’s avoiding wasting time. That’s why people resent it, if it’s not broke, don’t fix it.

    Cheers

Viewing 4 replies - 1 through 4 (of 4 total)

The topic ‘version 1.2 creating wp-block-embed’ is closed to new replies.