Video Opens in new Tab

Hi @aaron13223, I found the following code on your page that’s not standard:

(function(){var supportsPassive=eventListenerOptionsSupported();if(supportsPassive){var addEvent=EventTarget.prototype.addEventListener;overwriteAddEvent(addEvent);}
function overwriteAddEvent(superMethod){var defaultOptions={passive:true,capture:false};EventTarget.prototype.addEventListener=function(type,listener,options){var usesListenerOptions=typeof options==='object';var useCapture=usesListenerOptions?options.capture:options;options=usesListenerOptions?options:{};options.passive=options.passive!==undefined?options.passive:defaultOptions.passive;options.capture=useCapture!==undefined?useCapture:defaultOptions.capture;superMethod.call(this,type,listener,options);};}
function eventListenerOptionsSupported(){var supported=false;try{var opts=Object.defineProperty({},'passive',{get:function(){supported=true;}});window.addEventListener("test",null,opts);}catch(e){}
return supported;}})();

This code affects the EventTarget prototype and forces “passive: true” if the useCapture flag isn’t set. I made a change to my plugin that I believe should fix the issue for you. Please make sure you’re using at least WordPress v5.6.0, then download plugin version 2.13.0 and let me know if the issue is fixed.

• This reply was modified 5 years, 3 months ago by kevinweber.
• This reply was modified 5 years, 3 months ago by kevinweber.
• This reply was modified 5 years, 3 months ago by kevinweber.

@aaron13223 You can adjust your script to only set the passive flag if the passed in option doesn’t have the value true:

(function(){var supportsPassive=eventListenerOptionsSupported();if(supportsPassive){var addEvent=EventTarget.prototype.addEventListener;overwriteAddEvent(addEvent);}
function overwriteAddEvent(superMethod){var defaultOptions={passive:true,capture:false};EventTarget.prototype.addEventListener=function(type,listener,options){if(options!==true){var usesListenerOptions=typeof options==='object';var useCapture=usesListenerOptions?options.capture:options;options=usesListenerOptions?options:{};options.passive=options.passive!==undefined?options.passive:defaultOptions.passive;options.capture=useCapture!==undefined?useCapture:defaultOptions.capture;}superMethod.call(this,type,listener,options);};}
function eventListenerOptionsSupported(){var supported=false;try{var opts=Object.defineProperty({},'passive',{get:function(){supported=true;}});window.addEventListener("test",null,opts);}catch(e){}
return supported;}})();

This modified snippet as “if (options !== true) { … }” added within the addEventListener function call.

Great! Please consider leaving a quick rating here: https://ww.wp.xz.cn/support/plugin/lazy-load-for-videos/reviews/

Happy New Year 🙂

@jrgong Your page is throwing a JS error in a portion of the code that’s not related to the video plugin: “Uncaught ReferenceError: wp is not defined”

You can check out the error using DevTools in the browser. It seems to be related to the “generate-offside-js-extra” script where it runs “wp.i18n.setLocaleData( localeData, domain );”. The script might not be added to the page properly.

Hi @jrgong, the error message is gone. However, I found out what causes the link to open in a new window: An “onclick” attribute is being added to the video link that forces the link to open in a new tab. You must be using a plugin that causes this change, or your theme does this.

See: https://ibb.co/DVfVZVs

• This reply was modified 4 years, 10 months ago by kevinweber.
• This reply was modified 4 years, 10 months ago by kevinweber.