Thank you very much for reporting this, and we will take a look. Can you please provide any other info that might help us identify the cause: do you know what type of field it is checking and what the value in that field is?
Regards!
line 234 = $post_id = $_GET[‘post’];
Fixed:
global $post;
$post_id = isset($_GET[‘post’])?$_GET[‘post’]:$post->ID;
——————
line 235 = foreach(get_option(‘ns_seo_custom_fieldname’) as $fieldname){}
I think this is the cause get_option(‘ns_seo_custom_fieldname’) it is not set or empty.
Thank you very much for the suggestion. Is that change working for you?
I don’t understand why that fixes it though. Every time you are on a post edit page where both SEO for WordPress and NS Custom Fields are processing post metadata the url always looks like this:
/wp-admin/post.php?post=1&action=edit
And therefore the $_GET[‘post’] will always be valid, right? Or maybe I am missing something. What is an example admin URL you are on where it is not working for you with the old code?
Or… I just thought of something – were you maybe having that issue because you were on the Add New post edit page before an ID is assigned? A quick work-around would be to save the new post draft to get an ID in the URL and then it will work normally.
But if you have any other thoughts / feedback that would be great, and we’ll try to make this update as soon as possible.
Thanks!
Actually, I get it now… that is probably exactly what is going on. Bug was affecting Add New posts only. Fixed per your suggestion and provided credit to you in the code comments and readme.txt. Thank you for the catch and fix!
welcome and thanks for this very useful plugin.
Hi Author,
Here’s also I found out that if you enable the wp debug the plugin throws a warning in the frontend.
Warning: Invalid argument supplied for foreach() in /home/abc/public_html/sub abc/wp-content/plugins/ns-seo-custom-fields/ns-seo-custom-fields.php on line 237
What I did to fixed the warning, I did just put a checking of value before passing it to foreach.
if(get_option(‘ns_seo_custom_fieldname’)){
foreach(){
….
}
}
Thanks
Thanks again for the additional find. We’ll get it incorporated soon!
