why custom is_ssl test?

  • Resolved webaware

    (@webaware)


    13 years ago

    G’day Jason,

    Nice plugin, I try to push it wherever I see someone trying to replace jQuery with a CDN version 🙂

    Q: why are you doing the is_ssl test yourself, when WordPress does this already in the is_ssl() function? What you’re doing (since you fixed the port number!) isn’t any better than what WordPress is doing itself.

    BTW, it still won’t work behind a reverse proxy (nor will is_ssl()) but there are host-specific workarounds for that so you shouldn’t join that game anyway.

    cheers,
    Ross

    http://ww.wp.xz.cn/extend/plugins/use-google-libraries/

Viewing 10 replies - 1 through 10 (of 10 total)
  • Plugin Author Jason Penney

    (@jczorkmid)

    13 years ago

    When I wrote that, WordPress had no such method. Do you know when it was added?

    Thread Starter webaware

    (@webaware)

    13 years ago

    @since 2.6.0

    Plugin Author Jason Penney

    (@jczorkmid)

    13 years ago

    That explains it, UGL supported WordPress 2.4 when it launched. Probably don’t still need it.

    Thread Starter webaware

    (@webaware)

    13 years ago

    Yeah, shouldn’t be too many people using 2.4 any more, and I doubt any of them will have UGL (not updated anyway!)

    http://w3techs.com/technologies/details/cm-wordpress/all/all

    http://w3techs.com/technologies/details/cm-wordpress/2/all

    Plugin Author Jason Penney

    (@jczorkmid)

    13 years ago

    But, if you have 3.5 or greater, is_ssl isn’t called, so it’s a bit of a wash there. I’ll clean it up next time I’m doing something else in there. Thanks for pointing it out.

    Thread Starter webaware

    (@webaware)

    13 years ago

    Why not? (re: >= 3.5)

    Plugin Author Jason Penney

    (@jczorkmid)

    13 years ago

    Oh, I take that back. WP 3.5 added support for protocol relative URLs, and I added support for that to UGL, but apparently I never committed it to SVN and released that code. Whoops!

    Thread Starter webaware

    (@webaware)

    13 years ago

    Ah. That would be nice, better than playing the is_ssl() game all the time 🙂

    Plugin Author Jason Penney

    (@jczorkmid)

    13 years ago

    Ok, 1.5.2 uses protocol relative URLS on 3.5+, otherwise: is_ssl().

    wolfgang1949

    (@wolfgang1949)

    13 years ago

    Hello Jason, I just wanted to let you know that before the recent update everything seemed to be working fine, but since the update I have found that it conflicts with a plugin (Glass magnifier) that is important for my jewelry site.

    I have deactivated it for now.

Viewing 10 replies - 1 through 10 (of 10 total)

The topic ‘why custom is_ssl test?’ is closed to new replies.