width and max-with and br hardcoded

  • visitor

    (@gerritschuster)


    2 years, 11 months ago

    Thank you so much for your awesome Plugin! I like the simplicity a lot.

    Some things that do not work good for me: I think you mixed width and max-with. width should be 100% and max-width a pixel amount. Is that possible?
    And if I want to show a text under the video, there is a <br> that defines the distance from the player. Do you think, you could define some classes, that people can style individually? Instead of hardcoding the styles directly into the elements?

    And do you prevent setting a target="_blank" in the links? 🙂

    PS: you are putting a 5px margin around everything as well and hardcode it. I do not understand why.

    • This topic was modified 2 years, 11 months ago by visitor.
    • This topic was modified 2 years, 11 months ago by visitor.
Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author Optimizing Matters

    (@optimizingmatters)

    2 years, 11 months ago

    Hey Gerrit;
    width & max-width are on purpose; the goal is to ensure that the LYTE’s width is never wider then the width of the containing node (div).

    The <br> can be overridden with e.g. div.lL br {display:none;}

    The margin with div.lyte-wrapper{margin:0px !important;}

    The “disclaimer text” gets sanitized with the WordPress core wp_kses_data, which seems to remove the target indeed, I guess you could use a core filter to allow the target? 🙂

    hope this helps,
    frank

    Thread Starter visitor

    (@gerritschuster)

    2 years, 11 months ago

    Thank you Frank. It works like that mostly. 🙂 the br I cannot get rid of. But I solved it by moving the whole iL 16px up. I still think you mixed the values of width and max-width. But it works anyway.

    Thank you!

Viewing 2 replies - 1 through 2 (of 2 total)

The topic ‘width and max-with and br hardcoded’ is closed to new replies.